Update SDK, allow Facebook to use Chrome Custom Tabs #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: If37b630e311a5b6fcb329cfa8daf57a65dea29e8
|
PTAL |
| @@ -9,6 +9,16 @@ | |||
| --> | |||
| <string name="facebook_application_id" translatable="false">CHANGE-ME</string> | |||
|
|
|||
| <!-- | |||
| To enable Chrome Custom Tabs for Facebook Login on devices without the Facebook app | |||
There was a problem hiding this comment.
I'm a little unclear here. If they don't want to enable Chrome Custom Tabs can they do nothing and have it work? Or will it try to use fbYOUR_APP_ID as the facebook_login_protocol_scheme and break.
There was a problem hiding this comment.
In my testing when you have a misconfigured custom tabs setup (scheme = fbYOUR_APP_ID) it acts as if you had no custom tabs setup and falls back onto the normal webview flow.
Likely the FB SDK asks the system to handle the URL with your App ID, the system says there are no registered intent handlers, and it falls back.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #214
@amandle please review