Make tests run/pass #260
Merged
Make tests run/pass #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This necessitated an SDK downgrade from M to N since Robolectric does not yet support API 24. While it seems strange to go backwards here, it's important that these tests pass and there's no workaround I'm aware of. Change-Id: I479000e18581d6b7c36eb3929ba73f12fcff0be0
Change-Id: Ic2d3db1fbdbc1a62b06f5481f4a30bf8944c80d9
Change-Id: I745c2bb2915da4342fc4452cc90cf12a59c4e045
Change-Id: I9cd6226cf3e724582ae479cc0bf016098d1b89ee
|
cc @morganchen12, getting things test-y |
|
@amandle any thoughts on this? |
|
LGTM, I can't think of any reasons why downgrading would cause issues and getting the tests running is pretty crucial. Thanks for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@amandle PTAL
Embarassingly we haven't been running our tests at all, so much so that I only now realized that Robolectric does not support API 24.
I made some changes to make all the tests pass again, but it requires a downgrade of the compileSdkVersion (and therefore a downgrade of the support libraries).
Since we have no Android N features I don't think this should cause any problems, and developers can always override our support lib dependency if they are using N features heavily.
WDYT? I think having green tests on Travis is worth it.