-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Handle on cancelled #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Handle on cancelled #282
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f3fef79
Handle onCancelled
SUPERCILEX 4a414c6
Handle onCancelled
SUPERCILEX 3d8b1dc
Handle onCancelled
SUPERCILEX 3e5a130
Fix onCancelled using FirebaseRecyclerAdapter instead of FirebaseList…
SUPERCILEX 5b5305e
Add JavaDoc to onCancelled
SUPERCILEX 5fdcd08
Add JavaDoc to onCancelled
SUPERCILEX 0226aca
Make onCancelled optional
SUPERCILEX 95481a6
Make onCancelled optional
SUPERCILEX c262592
Add missing bracket
SUPERCILEX 0e6473f
Add missing import
SUPERCILEX a5ec416
Add missing import
SUPERCILEX fb10814
Add missing import
SUPERCILEX 0f34c40
Update FirebaseListAdapter.java
SUPERCILEX 720c558
Update FirebaseArray.java
SUPERCILEX File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,6 +28,7 @@ class FirebaseArray implements ChildEventListener { | |
public interface OnChangedListener { | ||
enum EventType { Added, Changed, Removed, Moved } | ||
void onChanged(EventType type, int index, int oldIndex); | ||
void onCancelled(DatabaseError databaseError); | ||
} | ||
|
||
private Query mQuery; | ||
|
@@ -94,20 +95,28 @@ public void onChildMoved(DataSnapshot snapshot, String previousChildKey) { | |
notifyChangedListeners(OnChangedListener.EventType.Moved, newIndex, oldIndex); | ||
} | ||
|
||
public void onCancelled(DatabaseError firebaseError) { | ||
// TODO: what do we do with this? | ||
public void onCancelled(DatabaseError databaseError) { | ||
notifyCancelledListeners(databaseError); | ||
} | ||
// End of ChildEventListener methods | ||
|
||
public void setOnChangedListener(OnChangedListener listener) { | ||
mListener = listener; | ||
} | ||
|
||
protected void notifyChangedListeners(OnChangedListener.EventType type, int index) { | ||
notifyChangedListeners(type, index, -1); | ||
} | ||
|
||
protected void notifyChangedListeners(OnChangedListener.EventType type, int index, int oldIndex) { | ||
if (mListener != null) { | ||
mListener.onChanged(type, index, oldIndex); | ||
} | ||
} | ||
|
||
protected void notifyCancelledListeners(DatabaseError databaseError) { | ||
if (mListener != null) { | ||
mListener.onCancelled(databaseError); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this method is missing a closing bracket. TravisCI says:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks! |
||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The symbol
databaseError
is not defined here,firebaseError
is what you called the method argument.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again! I'm working on another branch on my machine so I've been using the online file editor in Github. Yeah... It's tough without Intellij!