Version 0.5.2 #284
Merged
Version 0.5.2 #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Scopes for Google (firebase#281) * Gradle build fix (firebase#272) * README colorization for code snippets Change-Id: Ie35a987a027307f3eb092a241b6ca1ce1f21095d
Change-Id: Idb54fa4936e6c8af5db8f21e9d1c2ae0d9996729
| By default, FirebaseUI requests the `email` and `profile` scopes when using Google Sign In. If you | ||
| would like to request additional scopes from the user, add a string array resource to your | ||
| application like this: |
There was a problem hiding this comment.
Where do I add this? A new element in an existing file? Or is it a new file? If so, does the name of the file matter? Or is it only about the array's name?
|
A few comments. Aside from that lgtm. |
Change-Id: Ida7b0025654e25158f466074ce2d3a0674b577d6
|
@puf clarified XML setup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
@puf please review.