Skip to content

Refactor error handling #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2016
Merged

Conversation

samtstern
Copy link
Contributor

@samtstern samtstern commented Sep 7, 2016

Went through and looked at all error handling that uses TaskFailureLogger to ensure that each case has some sensible error handling beyond logging. In most cases I split onCompleteListener into separate onSuccessListener and onFailureListeners.

Also fixed a crash that can come from repeated uses of GoogleApiClientTaskHelper.

This addresses the following issues:

Change-Id: Ic362aaf75ba9eb5d26a83b77e64d491b3828db17
@samtstern
Copy link
Contributor Author

@amandle PTAL, this is a somewhat large refactor (although not much new logic, still room for errors)

@amandle
Copy link
Contributor

amandle commented Sep 8, 2016

@samtstern LGTM!

@samtstern samtstern merged commit 10a50cb into firebase:master Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants