Database tests, minor bugfix #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@puf please review |
|
@mcdonamp if you want me to skip 0.5.4 and go straight to 0.6.0 with basic storage stuff I could do that here too. Although I'd rather not now that I think about it. That involves docs and stuff. |
asciimike
reviewed
Sep 23, 2016
| mRef.removeValue(); | ||
| mArray.cleanup(); | ||
| if (mRef != null) { | ||
| mRef.removeValue(); |
There was a problem hiding this comment.
Just do this at the root of the database every time so you're sure nothing else is happening:
mref.getRoot().removeValue()
|
@samtstern let's do 0.6.0 with basic storage stuff |
|
@mcdonamp updated |
|
Squashed and merged |
amandle
pushed a commit
to amandle/FirebaseUI-Android
that referenced
this pull request
Oct 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the release of Play Services
9.6.0we need a patch update to this library.Also fixed #321 while I was at it.