Add and enforce checkstyle, lint, findbugs, and pmd #420
Conversation
# Conflicts: # build.gradle
…ndbugs # Conflicts: # auth/src/main/java/com/firebase/ui/auth/util/signincontainer/IdpSignInContainer.java
Apparently, the "message" in lint-baseline.xml has to match with the actual error which is a problem since version updates change the message each time.
|
See: #418 (comment) |
…ndbugs # Conflicts: # auth/build.gradle
|
@SUPERCILEX merged #418 first, which introduced a conflict here. I'll merge this next, and then #426. |
…tyle_pmd_findbugs # Conflicts: # auth/src/main/java/com/firebase/ui/auth/ui/email/AcquireEmailHelper.java # auth/src/main/java/com/firebase/ui/auth/ui/email/RegisterEmailActivity.java # auth/src/main/java/com/firebase/ui/auth/ui/email/SignInNoPasswordActivity.java # auth/src/main/java/com/firebase/ui/auth/ui/idp/AuthMethodPickerActivity.java # auth/src/test/java/com/firebase/ui/auth/ui/email/SignInNoPasswordActivityTest.java # auth/src/test/java/com/firebase/ui/auth/ui/idp/AuthMethodPickerActivityTest.java
Signed-off-by: Alex Saveau <[email protected]>
|
@samtstern merged. |
|
This is awesome! The build failed because I forgot to delete an unused string resource. |
|
That is cool, also I love describing a build failure as "awesome" 👍 |
Signed-off-by: Alex Saveau <[email protected]>
|
Yeah, "useful" would probably be a better word 😄 |
Signed-off-by: Alex Saveau <[email protected]>
|
That's one thing I wasn't sure about, do we want to enforce a max line length? |
|
@samstern, good to go! See my comment above though. |
|
@SUPERCILEX regarding max line length I don't think we need to enforce that, I generally try to keep my lines under 100 chars but I subscribe to the golang philosophy: 'Go has no line length limit. Don't worry about overflowing a punched card. If a line feels too long, wrap it and indent with an extra tab.' |
|
Hey, I think you have the wrong guy. Are you confusing me with @samtstern? |
|
@samstern yes I think he was, cool name though 😄 |
|
It's the BEST name!! |
|
Oops, sorry @samstern that was a typo 😄 |
I noticed two things that lead to this PR:
I started trying to get checkstyle to work and ended up adding all the common CI analysis tools/checks.
I went through and added checkstyle, lint, findbugs, and pmd. PMD is the only check that isn't enforced because it still needs to be configured to ignore tests. (It doesn't like the underscores in the test method names)
In the process, I fixed a ton of style and code issues.