Skip to content

Update AcquireEmailHelper.java #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

pahdo
Copy link
Contributor

@pahdo pahdo commented Nov 28, 2016

Changed request codes to public from private.

This is a sign-in example from the readme, which seems to require these request codes to be public.

startActivityForResult(
    // Get an instance of AuthUI based on the default app
    AuthUI.getInstance().createSignInIntentBuilder().build(),
    RC_SIGN_IN);

Changed request codes to public from private
@samtstern
Copy link
Contributor

@pahdo sorry I think the README is just not clear here.

You should define RC_SIGN_IN yourself (in your Activity) and then check for it in onActivityResult. These internal values are not what you are looking for and should remain private.

I am going to close this PR, appreciate your taking the time to do it! In general you should submit an issue before a PR so that things like this can be discussed (and maybe save you some time).

@samtstern samtstern closed this Nov 28, 2016
@SUPERCILEX
Copy link
Collaborator

@samtstern Sorry about that, I was actually using the RC_SIGN_IN from AcquireEmailHelper too so there might be an uptake of confused people because of #376.

@samtstern
Copy link
Contributor

@SUPERCILEX doesn't look like #376 changed the README at all, what change do you think may have caused this confusion/

@SUPERCILEX
Copy link
Collaborator

@samtstern It came from here and this conversation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants