Fix create account title not showing up (and cleanup strings) #484
Conversation
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
| <string name="name_hint">First & last name</string> | ||
| <string name="password_recovery_body">Get instructions sent to this email that explain how to | ||
| reset your password.</string> | ||
| <string name="create_account_title">Create account</string> |
There was a problem hiding this comment.
I changed this to "Sign up" to be more consistent with our progress dialog.
| <string name="invalid_email_address">That email address isn\'t correct</string> | ||
| <string name="missing_email_address">Enter your email address to continue</string> | ||
| <string name="error_weak_password">Password not strong enough. Use at least 6 characters and a mix of letters and numbers.</string> |
There was a problem hiding this comment.
Got rid of this; using the plural instead.
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
| <string name="title_check_email">@string/sign_in_default</string> | ||
| <string name="title_register_email_activity">@string/create_account_title</string> | ||
| <string name="title_recover_password_activity">@string/recover_password_title</string> | ||
| <string name="title_confirm_recover_password_activity">@string/check_your_email</string> |
There was a problem hiding this comment.
While these title_ strings are not part of the public API, I know there are some devs that do override them. We seem to have changed title_confirm_recover_password_activity to title_confirm_recover_password here, can we undo that just to keep the resource name as long as we can? Or is there a reason for the change?
There was a problem hiding this comment.
I meant to change it to title_confirm_recover_password_dialog because it's used in the dialog:
return new AlertDialog.Builder(getContext(), R.style.FirebaseUI_Dialog)
.setTitle(R.string.title_confirm_recover_password)@samtstern Would you like me to change it back to title_confirm_recover_password_activity or to title_confirm_recover_password_dialog?
There was a problem hiding this comment.
Ah if was never used as an Activity title it's fine as-is.
There was a problem hiding this comment.
It was an activity in the dark ages before #357 (comment). I just never changed the string name...
…p-strings # Conflicts: # auth/src/main/java/com/firebase/ui/auth/ui/accountlink/WelcomeBackIdpPrompt.java # auth/src/main/java/com/firebase/ui/auth/ui/accountlink/WelcomeBackPasswordPrompt.java # auth/src/main/java/com/firebase/ui/auth/ui/email/RecoveryEmailSentDialog.java # auth/src/main/java/com/firebase/ui/auth/ui/email/fieldvalidators/PasswordFieldValidator.java
Signed-off-by: Alex Saveau <[email protected]>
The original purpose of this PR was to fix this still saying "Sign in", but the
strings.xmlfile drove me crazy so I did a ton of cleanup there.