db sample cleanup #545
Merged
db sample cleanup #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
SUPERCILEX
commented
Jan 26, 2017
There was a problem hiding this comment.
@samtstern @puf do you guys think these are reasonable changes?
| @@ -60,8 +51,8 @@ | |||
|
|
|||
| private RecyclerView mMessages; | |||
| private LinearLayoutManager mManager; | |||
| private FirebaseRecyclerAdapter<Chat, ChatHolder> mRecyclerViewAdapter; | |||
| private View mEmptyListView; | |||
There was a problem hiding this comment.
Confusing name: empty listView or emptyList view.
| @@ -60,8 +51,8 @@ | |||
|
|
|||
| private RecyclerView mMessages; | |||
| private LinearLayoutManager mManager; | |||
| private FirebaseRecyclerAdapter<Chat, ChatHolder> mRecyclerViewAdapter; | |||
There was a problem hiding this comment.
Debatable: the documentation just uses mAdapter.
| // Sending only allowed when signed in | ||
| mSendButton.setEnabled(isSignedIn()); | ||
| mMessageEdit.setEnabled(isSignedIn()); | ||
| } | ||
|
|
||
| public static class Chat { |
There was a problem hiding this comment.
Putting these in separate files makes the ChatActivity easier to understand since it doesn't contain the java bean or holder.
…-cleanup # Conflicts: # app/src/main/java/com/firebase/uidemo/database/ChatActivity.java # app/src/main/res/values/strings.xml
|
@SUPERCILEX these look like good simplifications to me. Gonna squash and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samtstern Aaaaaaaaaahhh!!! I'm trying to move changes from #544 that aren't directly related to that PR away from it to simplify the diff.