Update documentation and sample for #544 #567

SUPERCILEX · 2017-02-01T06:22:23Z

This PR is built on top of #544 and updates documentation and the sample with the changes from #544. It should be merged only if #544 is merged.

Update README links in new adapters

Signed-off-by: Alex Saveau <[email protected]>

…lback

Signed-off-by: Alex Saveau <[email protected]>

…lback

Signed-off-by: Alex Saveau <[email protected]>

…lback

Signed-off-by: Alex Saveau <[email protected]>

…lback

Signed-off-by: Alex Saveau <[email protected]>

…lback # Conflicts: # app/src/main/java/com/firebase/uidemo/database/ChatActivity.java # database/src/main/java/com/firebase/ui/database/FirebaseArray.java # database/src/main/java/com/firebase/ui/database/FirebaseListAdapter.java # database/src/main/java/com/firebase/ui/database/FirebaseRecyclerAdapter.java

Signed-off-by: Alex Saveau <[email protected]>

# Conflicts: # database/src/main/java/com/firebase/ui/database/FirebaseArray.java

# Conflicts: # database/src/androidTest/java/com/firebase/ui/database/TestUtils.java

…aseUI-Android into db-callback

…lback # Conflicts: # app/src/main/java/com/firebase/uidemo/database/ChatActivity.java # database/src/androidTest/java/com/firebase/ui/database/TestUtils.java # database/src/main/java/com/firebase/ui/database/FirebaseArray.java # database/src/main/java/com/firebase/ui/database/FirebaseIndexArray.java # database/src/main/java/com/firebase/ui/database/FirebaseListAdapter.java # database/src/main/java/com/firebase/ui/database/FirebaseRecyclerAdapter.java

Signed-off-by: Alex Saveau <[email protected]>

… works Change-Id: I6a62e69a58d0023c5feffb0984613e8e95be2ecc

Change-Id: Ia72a6942c947464ade5070aa07fade1e133c0f8d

Change-Id: I831fd0bae52970ff7db6f4ab1ae2fdb7aa04200a

… object, change type name to `E` in ObservableSnapshotArray to unhide type T in toArray method, remove getSnapshots(int) method from FirebaseArray since there's already get(int), use `index` instead of `newIndex` in onKeyMove in FirebaseIndexArray Signed-off-by: Alex Saveau <[email protected]>

googlebot · 2017-03-01T20:45:25Z

CLAs look good, thanks!

Signed-off-by: Alex Saveau <[email protected]>

…seArray

Signed-off-by: Alex Saveau <[email protected]>

samtstern · 2017-03-06T03:28:38Z

@SUPERCILEX this one's next!

…itical-#544 # Conflicts: # database/src/main/java/com/firebase/ui/database/FirebaseRecyclerAdapter.java

Signed-off-by: Alex Saveau <[email protected]>

SUPERCILEX · 2017-03-06T03:36:34Z

@samtstern Merged!

SUPERCILEX · 2017-03-06T03:31:26Z

app/src/main/java/com/firebase/uidemo/database/ChatActivity.java

-        Query lastFifty = mChatRef.limitToLast(50);
-        mAdapter = new FirebaseRecyclerAdapter<Chat, ChatHolder>(
-                Chat.class, R.layout.message, ChatHolder.class, lastFifty) {
+        mAdapter = new FirebaseIndexRecyclerAdapter<Chat, ChatHolder>(


I have a really strong preference to keeping this since I was able to find issues with the index stuff by testing with this branch.

While I definitely appreciate your constant testing of the indexed bits, the purpose of ChatActivity is to show off the basic FBUI integration, and I think FirebaseRecyclerAdapter is the most popular. People are likely to copy and paste from this class and I want them to get the least surprising thing.

Is there somewhere else we can put the indexed code? Maybe in another Activity that's not exposed in the main chooser?

@samtstern Hmmm, I didn't think about people copypasta-ing code straight from ChatActivity... If that's the case, then I agree with you that the code should be as simple as possible and I like the idea of a separate activity for the index stuff. What do you think of 758b692?

SUPERCILEX · 2017-03-06T03:32:06Z

app/src/main/java/com/firebase/uidemo/database/ChatActivity.java

+                                                    View v,
+                                                    ContextMenu.ContextMenuInfo menuInfo) {
+                        menu.add("Delete")
+                                .setOnMenuItemClickListener(new MenuItem.OnMenuItemClickListener() {


Should we keep this? (I just did it for testing, but it's kinda nice)

I like the idea but the ratio of "lines of code" to "how much it teaches you about FirebaseUI" may be too low here. If you don't have a strong preference I'd say remove it to keep ChatActivity as short as possible.

samtstern · 2017-03-06T03:39:21Z

@SUPERCILEX thanks for merging! To be honest I have not looked at this one in many moons (was focusing on #544) so I will give it a pass in the morning. I don't expect this to take more than one round of back-and-forth before merging too, thanks for keeping this one up to date.

Signed-off-by: Alex Saveau <[email protected]>

samtstern · 2017-03-06T20:59:30Z

LGTM! Gonna squash and merge.

SUPERCILEX · 2017-03-06T21:02:29Z

Awesome!

SUPERCILEX added 30 commits December 8, 2016 19:48

Add a callback in FirebaseIndexArray when a Key doesn't exist in a ref

28c366c

Signed-off-by: Alex Saveau <[email protected]>

Add documentation

641297c

Signed-off-by: Alex Saveau <[email protected]>

Rename listeners

a62a025

Signed-off-by: Alex Saveau <[email protected]>

Merge remote-tracking branch 'firebase/version-1.1.0-dev' into db-cal…

703f85d

…lback

Add JoinResolver.java interface

f1e702b

Signed-off-by: Alex Saveau <[email protected]>

Cleanup

af39a1e

Signed-off-by: Alex Saveau <[email protected]>

Rename ChangeListener to ChangeEventListener

25fc4df

Signed-off-by: Alex Saveau <[email protected]>

Cleanup

5486e8c

Signed-off-by: Alex Saveau <[email protected]>

Make JoinResolver.java public

23806d7

Signed-off-by: Alex Saveau <[email protected]>

Merge remote-tracking branch 'firebase/version-1.1.0-dev' into db-cal…

06fb7d0

…lback

Merge remote-tracking branch 'firebase/version-1.1.0-dev' into db-cal…

0b56e99

…lback

Rename

331b4bf

Signed-off-by: Alex Saveau <[email protected]>

Merge remote-tracking branch 'firebase/version-1.1.0-dev' into db-cal…

f396fec

…lback

Fix compile error

cfdb305

Signed-off-by: Alex Saveau <[email protected]>

Merge branch 'version-1.1.0-dev' into db-callback

cc3729c

Merge remote-tracking branch 'firebase/version-1.1.0-dev' into db-cal…

f5d06b2

…lback

Make FirebaseArray.java fully decked out and implementing List

2b65f11

Signed-off-by: Alex Saveau <[email protected]>

Make stuff public

961f9d7

Signed-off-by: Alex Saveau <[email protected]>

Fix merge mistakes

97d9cb0

Signed-off-by: Alex Saveau <[email protected]>

Merge branch 'db-callback' into FirebaseArray

0f11146

# Conflicts: # database/src/main/java/com/firebase/ui/database/FirebaseArray.java

Merge remote-tracking branch 'firebase/master' into FirebaseArray

460b733

# Conflicts: # database/src/androidTest/java/com/firebase/ui/database/TestUtils.java

Merge remote-tracking branch 'firebase/master' into db-callback

e7297d4

# Conflicts: # database/src/androidTest/java/com/firebase/ui/database/TestUtils.java

Merge remote-tracking branch 'firebase/master' into db-callback

9a03342

Merge branch 'version-1.2.0-dev' of https://github.com/firebase/Fireb…

8f87492

…aseUI-Android into db-callback

Fix a ton of merge mistakes

48ea75a

Signed-off-by: Alex Saveau <[email protected]>

Provide default join resolver

4a5a1be

Signed-off-by: Alex Saveau <[email protected]>

Fix tests and bugs

dbbf0dc

Signed-off-by: Alex Saveau <[email protected]>

Cleanup

b37c8bd

Signed-off-by: Alex Saveau <[email protected]>

SUPERCILEX and others added 10 commits February 24, 2017 12:51

Merge branch 'FirebaseArray' into non-critical-#544

0bf8e37

Initial commit of refactor. Far from done, but enough that the sample…

fdf9be8

… works Change-Id: I6a62e69a58d0023c5feffb0984613e8e95be2ecc

Clean up some TODOs, make the tests compile, some tests pass.

03d6bf4

Change-Id: Ia72a6942c947464ade5070aa07fade1e133c0f8d

Tests pass, TODOs resolved, code made DRY

a38c1b2

Change-Id: I831fd0bae52970ff7db6f4ab1ae2fdb7aa04200a

Fix build and docs

a87a0d9

Respond to review comments

51b05e6

Make FirebaseAdapter protected

be09c80

Merge branch 'FirebaseArray' into firebase-array-explore

a4d7ad1

Merge branch 'FirebaseArray' into non-critical-#544

869317a

SUPERCILEX added 7 commits March 1, 2017 12:55

Fix compile errors

8d63cfb

Signed-off-by: Alex Saveau <[email protected]>

Remove null parser possibility and fix broken FirebaseIndexAdapters

7601ded

Signed-off-by: Alex Saveau <[email protected]>

Merge branch 'FirebaseArray' into non-critical-#544

4554735

Merge remote-tracking branch 'firebase/version-2.0.0-dev' into Fireba…

fa6265e

…seArray

Merge branch 'FirebaseArray' into non-critical-#544

7596751

Fix circular SnapshotParser dependency in adapters

42c639a

Signed-off-by: Alex Saveau <[email protected]>

Merge branch 'FirebaseArray' into non-critical-#544

6c916ea

SUPERCILEX added 2 commits March 5, 2017 19:29

Merge remote-tracking branch 'firebase/version-2.0.0-dev' into non-cr…

569717a

…itical-#544 # Conflicts: # database/src/main/java/com/firebase/ui/database/FirebaseRecyclerAdapter.java

Fix typos

20c15a3

Signed-off-by: Alex Saveau <[email protected]>

SUPERCILEX commented Mar 6, 2017

View reviewed changes

SUPERCILEX added 2 commits March 5, 2017 20:16

Address review comments

b2ffadf

Signed-off-by: Alex Saveau <[email protected]>

Add separate activity for index stuff

758b692

Signed-off-by: Alex Saveau <[email protected]>

samtstern merged commit cf144b4 into firebase:version-2.0.0-dev Mar 6, 2017

SUPERCILEX deleted the non-critical-#544 branch March 6, 2017 21:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update documentation and sample for #544 #567

Update documentation and sample for #544 #567

Uh oh!

SUPERCILEX commented Feb 1, 2017 •

edited

Loading

Uh oh!

googlebot commented Mar 1, 2017

Uh oh!

samtstern commented Mar 6, 2017

Uh oh!

SUPERCILEX commented Mar 6, 2017

Uh oh!

SUPERCILEX Mar 6, 2017

Uh oh!

samtstern Mar 6, 2017

Uh oh!

SUPERCILEX Mar 6, 2017

Uh oh!

SUPERCILEX Mar 6, 2017

Uh oh!

samtstern Mar 6, 2017

Uh oh!

SUPERCILEX Mar 6, 2017

Uh oh!

samtstern commented Mar 6, 2017

Uh oh!

samtstern commented Mar 6, 2017

Uh oh!

SUPERCILEX commented Mar 6, 2017

Uh oh!

Uh oh!

Update documentation and sample for #544 #567

Update documentation and sample for #544 #567

Uh oh!

Conversation

SUPERCILEX commented Feb 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented Mar 1, 2017

Uh oh!

samtstern commented Mar 6, 2017

Uh oh!

SUPERCILEX commented Mar 6, 2017

Uh oh!

SUPERCILEX Mar 6, 2017

Choose a reason for hiding this comment

Uh oh!

samtstern Mar 6, 2017

Choose a reason for hiding this comment

Uh oh!

SUPERCILEX Mar 6, 2017

Choose a reason for hiding this comment

Uh oh!

SUPERCILEX Mar 6, 2017

Choose a reason for hiding this comment

Uh oh!

samtstern Mar 6, 2017

Choose a reason for hiding this comment

Uh oh!

SUPERCILEX Mar 6, 2017

Choose a reason for hiding this comment

Uh oh!

samtstern commented Mar 6, 2017

Uh oh!

samtstern commented Mar 6, 2017

Uh oh!

SUPERCILEX commented Mar 6, 2017

Uh oh!

Uh oh!

SUPERCILEX commented Feb 1, 2017 •

edited

Loading