Remove all deprecated stuff #609
Conversation
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
|
Something else I just thought of: making any decision sets a precedent so if we don't remove stuff, people might expect deprecations to never be removed in the future. |
| * @param activity the activity requesting the user be signed out | ||
| * @return A task which, upon completion, signals that the user has been signed out ({@link | ||
| * Task#isSuccessful()}, or that the sign-out attempt failed unexpectedly !{@link | ||
| * Task#isSuccessful()}). | ||
| */ | ||
| public Task<Void> signOut(@NonNull FragmentActivity activity) { | ||
| // Get Credentials Helper | ||
| GoogleSignInHelper credentialsHelper = GoogleSignInHelper.getInstance(activity); |
There was a problem hiding this comment.
Note: in the future let's try to avoid changes like this where we do a cosmetic refactor within another change. It makes the diff larger and distracts from your main purpose (which is killing deprecated code).
| @@ -254,12 +184,8 @@ public Void then(@NonNull Task<GoogleApiClient> task) throws Exception { | |||
| */ | |||
| public Task<Void> delete(@NonNull FragmentActivity activity) { | |||
| // Initialize SmartLock helper | |||
| CredentialTaskApi credentialHelper = GoogleSignInHelper.getInstance(activity); | |||
|
|
|||
| return getDeleteTask(credentialHelper); | |||
There was a problem hiding this comment.
Same comment here, I have no issue with inlining this method but it's not relevant to the title of the PR.
There was a problem hiding this comment.
Yeah, sorry about that. These changes were introduced when deprecating the old delete(Activity) method which is why I undid them here, but I can see your point of how that's confusing.
| * @deprecated Please use {@link com.firebase.ui.auth.ErrorCodes#NO_NETWORK} | ||
| **/ | ||
| @Deprecated | ||
| public static final int RESULT_NO_NETWORK = com.firebase.ui.auth.ErrorCodes.NO_NETWORK; |
There was a problem hiding this comment.
We should probably keep a running list of 1.x --> 2.x upgrade tips since something like this will be a little confusing. Not sure what the best format for this is, maybe an MD file?
There was a problem hiding this comment.
@samtstern Totally agree with you, 1113cc0 should take care of this.
…-deprecations # Conflicts: # auth/src/main/java/com/firebase/ui/auth/AuthUI.java
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
…-deprecations # Conflicts: # auth/src/main/java/com/firebase/ui/auth/AuthUI.java
…-deprecations # Conflicts: # auth/src/test/java/com/firebase/ui/auth/AuthUITest.java
…-deprecations # Conflicts: # auth/src/main/java/com/firebase/ui/auth/AuthUI.java
…-deprecations # Conflicts: # auth/src/main/java/com/firebase/ui/auth/ui/idp/AuthMethodPickerActivity.java
…-deprecations # Conflicts: # auth/src/main/java/com/firebase/ui/auth/ui/BaseHelper.java
|
@SUPERCILEX this CL has been here forever ... I've been thinking about it and 2.0 is the time to kill anything that was Do you have any reservations about merging this change? |
|
@samtstern Nope, LGTM! 😄 We're still keeping the deprecated |
|
Yeah we have to keep that method since it was never actually released as |
|
Cool beans! 😄 |
@samtstern What do you think, should we do it? On the one hand, this removes 400+ lines of code and cleans things up nicely, but on the other hand it could make it harder for people to upgrade if they were still using the deprecated stuff.