Cleanup index array #632
Merged
Cleanup index array #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Saveau <[email protected]> (cherry picked from commit 371c211) Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
SUPERCILEX
commented
Mar 14, 2017
| } | ||
| } | ||
|
|
||
| protected void onKeyRemoved(DataSnapshot data, int index) { | ||
| String key = data.getKey(); | ||
| mDataRef.child(key).removeEventListener(mRefs.remove(mDataRef.getRef().child(key))); | ||
| ValueEventListener listener = mRefs.remove(mDataRef.getRef().child(key)); | ||
| if (listener != null) mDataRef.child(key).removeEventListener(listener); |
There was a problem hiding this comment.
My app keeps crashing randomly with NPEs so I'm starting to think this could be getting called twice in really weird cases. Unfortunately, I've never been able to consistently reproduce it, but it can't hurt to add a null check.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.