Update deps #703
Update deps #703
Conversation
Signed-off-by: Alex Saveau <[email protected]>
# Conflicts: # constants.gradle
# Conflicts: # auth/src/main/res/values/styles.xml
app/build.gradle
Outdated
| @@ -42,12 +41,12 @@ dependencies { | |||
| // The following dependencies are not required to use the Firebase UI library. | |||
| // They are used to make some aspects of the demo app implementation simpler for | |||
| // demonstrative purposes, and you may find them useful in your own apps; YMMV. | |||
| compile 'pub.devrel:easypermissions:0.3.0' | |||
| compile 'pub.devrel:easypermissions:0.3.1' | |||
There was a problem hiding this comment.
Yup, I started writing this PR awhile ago so I haven't kept up. 😆
library/quality/quality.gradle
Outdated
| disable 'InvalidPackage', 'NewerVersionAvailable', 'GradleDependency' | ||
| disable 'InvalidPackage', | ||
| 'NewerVersionAvailable', 'GradleDependency', // For reproducible builds | ||
| 'GradleCompatible' // TODO remove once the tools team fixes lint |
There was a problem hiding this comment.
What's wrong with lint right now?
auth/src/main/res/values/styles.xml
Outdated
| @@ -31,33 +31,6 @@ | |||
| <item name="android:fontFamily">sans-serif</item> | |||
| </style> | |||
|
|
|||
| <style name="FirebaseUI.Text.T01"> | |||
There was a problem hiding this comment.
Can we drop this non-dependency change from this PR?
| @@ -99,21 +99,20 @@ public View onCreateView(LayoutInflater inflater, | |||
|
|
|||
| View v = inflater.inflate(R.layout.register_email_layout, container, false); | |||
|
|
|||
| mPasswordFieldValidator = new PasswordFieldValidator( | |||
There was a problem hiding this comment.
Can we drop this non-dependency change from this PR?
There was a problem hiding this comment.
Yup to both of your comments since I had to downgrade the gradle plugin, otherwise lint will complain.
There was a problem hiding this comment.
@samtstern Hmmm, updating the Gradle plugin breaks our tests so it looks like we can't upgrade to Java 8 until that's fixed. 😢
| getResources().getInteger(R.integer.min_password_length)); | ||
| mNameValidator = new RequiredFieldValidator( | ||
| (TextInputLayout) v.findViewById(R.id.name_layout)); | ||
| mEmailFieldValidator = new EmailFieldValidator(mEmailInput); |
There was a problem hiding this comment.
This is really cool! Lint has a new check for copypasta errors and it detected that we were calling v.findViewById(R.id.password_layout) twice. Pretty awesome! 😄
auth/src/main/res/values/styles.xml
Outdated
| <style name="FirebaseUI.Text.T06"> | ||
| <item name="android:textSize">18sp</item> | ||
| <item name="android:lineSpacingExtra">6sp</item> | ||
| </style> |
There was a problem hiding this comment.
Lint complained about this, turns out we weren't using them.
build.gradle
Outdated
| @@ -25,20 +24,6 @@ allprojects { | |||
| } | |||
| } | |||
|
|
|||
| // TODO Remove once either Facebook or Robolectric fix the crash: https://github.com/robolectric/robolectric/issues/2579#issuecomment-276526911 | |||
| gradle.taskGraph.whenReady { graph -> | |||
There was a problem hiding this comment.
Yay, Facebook merged my PR!
There was a problem hiding this comment.
Nice! Isn't there some hack we put in the manifest we can remove now too? Or was that unrelated.
There was a problem hiding this comment.
@samtstern It looks like the commit that fixed this didn't end up in the new Facebook release anyway unfortunately. As for the other issue, I believe that was unrelated though I'm not sure...
| @@ -22,13 +22,11 @@ android { | |||
| } | |||
|
|
|||
| dependencies { | |||
| compile "com.android.support:appcompat-v7:$supportLibraryVersion" | |||
There was a problem hiding this comment.
Ouch, we were unnecessarily pulling in appcompat. 😕
build.gradle
Outdated
| @@ -25,20 +24,6 @@ allprojects { | |||
| } | |||
| } | |||
|
|
|||
| // TODO Remove once either Facebook or Robolectric fix the crash: https://github.com/robolectric/robolectric/issues/2579#issuecomment-276526911 | |||
| gradle.taskGraph.whenReady { graph -> | |||
There was a problem hiding this comment.
Nice! Isn't there some hack we put in the manifest we can remove now too? Or was that unrelated.
| @@ -22,13 +22,11 @@ android { | |||
| } | |||
|
|
|||
| dependencies { | |||
| compile "com.android.support:appcompat-v7:$supportLibraryVersion" | |||
|
@samtstern That was a mess, but the build finally passed! 😄 |
No description provided.