Fix broken picker layout on small screens #711
Conversation
|
@SUPERCILEX thank you for this! I want to hold this until after 2.0, this is clearly an improvement but I am wondering if we can do even better (esp for the scrolling buttons part). Once 2.0 goes out I will have some UX people take a look and we can put this into 2.1 (or whatever the next version is) |
|
@samtstern yeah, it would be nice to have designers look at this (I don't know about you, but UX isn't my strong suit 😂). |
…-layout # Conflicts: # auth/src/main/res/layout-land/auth_method_picker_layout.xml # auth/src/main/res/layout/auth_method_picker_layout.xml # auth/src/main/res/layout/include_auth_method_picker_logo.xml
…-layout # Conflicts: # .travis.yml # gradle/wrapper/gradle-wrapper.jar # gradle/wrapper/gradle-wrapper.properties
|
@samtstern I know you said you wanted designers to take a look at this, but in the meantime I feel like any improvement is better than none... Especially since you can now have 5 providers with phone auth which looks like 💩 and is completely unusable in landscape mode. Oops! 😀 |
|
@samtstern lol now that I'm trying to break the picker, I've found more 💩😂. If we enable accessibility settings to boost the text size, the following happens both with and without this PR: I'll try to submit a PR fixing that at some point soon. |
…-layout # Conflicts: # auth/src/main/java/com/firebase/ui/auth/ui/idp/AuthMethodPickerActivity.java
|
@samtstern Merged! 😄 Dunno if you read my previous comment, but this PR should really be merged to make the picker layout look nice when using all the providers. The screenshot with GitHub oauth is how it looks with phone auth since we now have 5 providers. |
…-layout # Conflicts: # auth/src/main/res/layout-land/auth_method_picker_layout.xml
|
@samtstern gentle bump |
|
@SUPERCILEX thanks for bumping this, will take a look soon. Good candidate for |
…-layout # Conflicts: # auth/src/main/res/layout-land/fui_auth_method_picker_layout.xml # auth/src/main/res/layout/fui_auth_method_picker_layout.xml # auth/src/main/res/layout/fui_include_auth_method_picker_logo.xml # auth/src/main/res/values-sw360dp/dimens.xml # auth/src/main/res/values/dimens.xml # auth/src/main/res/values/styles.xml
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
|
@samtstern Merged! 😄 I also fixed the word wrapping while I was at it:
|
|
Thanks for merging everything into this. We will still need some follow up improvements ( This is the worst I could do to it. Nexus 4, split screen, landscape: |
|
@samtstern Yeah, we need designers cuz I can't think of anything better than For your case, I think we can set a |
@samtstern With the addition of the GitHub provider, the main auth picker layout looked really bad. This PR fixes that with
ConstraintLayout. Yay!!! 😄 🚀 🎉I also wrapped the auth buttons in a
ScrollViewso they are guaranteed to be usable.New layout edge cases