Add support for night mode #749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samtstern I updated the base for this PR to 2.1 |
|
@samtstern what are your thoughts on this? |
samtstern
reviewed
Jun 15, 2017
|
|
||
| import com.squareup.leakcanary.LeakCanary; | ||
| import com.squareup.leakcanary.RefWatcher; | ||
|
|
||
| public class LeakCatcher extends Application { | ||
| private RefWatcher mRefWatcher; | ||
|
|
||
| static { | ||
| AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_AUTO); |
There was a problem hiding this comment.
Feels a little strange to do this in a class called 'LeakCatcher'. Also should we use 'MODE_NIGHT_SYSTEM' to respect the system setting?
There was a problem hiding this comment.
@samtstern Same, I was just being lazy. 😄
|
@samtstern As for the whole night mode thing, I've been really getting into AppCompat's coolness and I found these great resources which should clear things up for you: |
TL;DR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samtstern Dang, I completely forgot about the night mode issue but the styling PR was the best desision ever! 😄 It just works™️
Here are a bunch of screenshots I took while testing, everything LGTM!
