Code inspect cleanup #785
Merged
Code inspect cleanup #785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, and I forgot to mention that it's built on top of #784. |
Merged
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
…nspect-cleanup # Conflicts: # auth/src/main/java/com/firebase/ui/auth/provider/FacebookProvider.java # auth/src/main/java/com/firebase/ui/auth/provider/TwitterProvider.java # auth/src/main/java/com/firebase/ui/auth/ui/phone/CountryListSpinner.java # auth/src/main/java/com/firebase/ui/auth/ui/phone/PhoneVerificationActivity.java
SUPERCILEX
commented
Jul 5, 2017
| @@ -156,7 +156,7 @@ public void onCreate(Bundle savedInstanceState) { | |||
| return; | |||
| } | |||
|
|
|||
| if (!isGoogleConfigured()) { | |||
| if (isGoogleMisconfigured()) { | |||
There was a problem hiding this comment.
Intellij said we were always inverting these.
| import com.firebase.ui.auth.IdpResponse; | ||
|
|
||
| public interface IdpProvider extends Provider { | ||
| interface IdpCallback { | ||
| void onSuccess(IdpResponse idpResponse); | ||
|
|
||
| void onFailure(Bundle extra); | ||
| void onFailure(); |
There was a problem hiding this comment.
We never use this bundle anywhere.
| public interface Provider { | ||
| /** Retrieves the name of the IDP, for display on-screen. */ | ||
| String getName(Context context); | ||
|
|
||
| /** Retrieves the id of the IDP, e.g. {@link GoogleAuthProvider#PROVIDER_ID}. */ | ||
| String getProviderId(); |
There was a problem hiding this comment.
We never use this anywhere which makes sense since most of the time we need the provider id to figure out which class to instantiate. Thus, we would already have the provider id by the time we get an instance of a Provider.
| if (t != null) { | ||
| mCountdownTimer.update(t); | ||
| } | ||
| mCountdownTimer.update(savedInstanceState.getLong(EXTRA_MILLIS_UNTIL_FINISHED)); |
There was a problem hiding this comment.
getLong returns a long, not a Long so it's always going to be non-null.
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does an Intellij code inspect and changes some semantics which is why I separated it from the style refactor PR.