Twitter integration #131
Twitter integration #131
Conversation
yramanchuk
commented
Sep 15, 2016
yramanchuk
commented
- Implemented Twitter Provider for Firebase Auth UI
- Implemented Obj-C demo for Twiter Provider
…nto twitter-integration * 'master' of https://github.com/firebase/FirebaseUI-iOS: add ruby and pod versions to travis yml fix nonexistant scheme in travis yml fix auth tests move files around in auth tests fix licensing header add auth provider test update comment only ignore googleservice plists in samples move around gitignore stuff initial FIRAuthUI tests clean up (no code changes) # Conflicts: # FirebaseUI.xcodeproj/project.pbxproj
| #import "FIRTwitterAuthUI.h" | ||
|
|
||
| /** @var kBundleFileName | ||
| @brief The name of the bundle containing Facebook auth provider assets/resources. |
There was a problem hiding this comment.
Change Facebook to Twitter in comment
| */ | ||
| static NSString *const kTableName = @"FirebaseTwitterAuthUI"; | ||
|
|
||
| /** @var kSignInWithFacebook |
There was a problem hiding this comment.
change to kSignInWithTwitter
|
Looks like travis ci isn't running |
| [FIRAuthUIErrorUtils providerErrorWithUnderlyingError:error | ||
| providerID:FIRTwitterAuthProviderID]; | ||
| if (completion) { | ||
| completion(nil, error); |
There was a problem hiding this comment.
Should this be completion(nil, newError)?
There was a problem hiding this comment.
fixed in both cases: completion(credential, nil); and completion(nil, newError)
| //! Project version string for FirebaseTwitterAuthUI. | ||
| FOUNDATION_EXPORT const unsigned char FirebaseTwitterAuthUIVersionString[]; | ||
|
|
||
| #import <FirebaseTwitterAuthUI/FIRTwitterAuthUI.h> |
There was a problem hiding this comment.
FIRTwitterAuthUI.h needs to be marked as a Public header (not Project header) or it'll cause build errors when integrating as a framework.
| @@ -7,6 +7,14 @@ | |||
| objects = { | |||
There was a problem hiding this comment.
The FirebaseTwitterAuthUI target needs to have a target dependency on FirebaseAuthUI or it won't compile.
