Allow elements to be moved to start of FirebaseArray (potential fix for #129) #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morganchen12
requested changes
Oct 7, 2016
| @@ -123,7 +123,11 @@ - (void)initListeners { | |||
| NSUInteger fromIndex = [self indexForKey:snapshot.key]; | |||
| [self.snapshots removeObjectAtIndex:fromIndex]; | |||
|
|
|||
| NSUInteger toIndex = [self indexForKey:previousChildKey] + 1; | |||
| NSUInteger toIndex = 0; | |||
| NSUInteger prevIndex = [self indexForKey:previousChildKey]; | |||
There was a problem hiding this comment.
We should be handling the case where the previous child key is nil as well here
| }; | ||
|
|
||
| // Move 8 to the start | ||
| [self.observable sendEvent:FIRDataEventTypeChildMoved withObject:self.snap previousKey:@"" error:nil]; |
There was a problem hiding this comment.
Can you add a case like this where previous key is nil as well? Other than that this change looks good.
|
I've added in the changes. I'm not sure exactly why the CI build failed.. there's quite a few |
morganchen12
approved these changes
Oct 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using FirebaseTableViewDataSource I was seeing something like the following when moving an object to the start of a list.
Assertions: failed: caught "NSRangeException", "*** -[__NSArrayM insertObject:atIndex:]: index 9223372036854775807 beyond bounds [0 .. 8]"It looks like it was caused by the
FIRDataEventTypeChildMovedbeing sent apreviousChildKeythat doesn't exist in the array (presumably ""). This is similar to #129 and is potentially a fix for that.