Anonymous user upgrade federated #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morganchen12
approved these changes
Feb 1, 2018
There was a problem hiding this comment.
Had a question and a nit, otherwise LGTM
Please merge #403 first and check that travis passes.
FirebaseAuthUI/FUIAuth.h
Outdated
| /** @property autoUpgradeAnonymousUsers | ||
| @brief Whether to enable auto upgrading of anonymous accounts, defaults to NO. | ||
| */ | ||
| @property(nonatomic, assign, getter=isAutoUpgradeAnonymousUsers) BOOL autoUpgradeAnonymousUsers; |
There was a problem hiding this comment.
nit: rename this to shouldAutoUpgradeAnonymousUsers (for both getter and setter)
| FIRUser *currentUser = self.authUI.auth.currentUser; | ||
| // If the user is anonymous, delete the user to avoid dangling anonymous users. | ||
| if (currentUser.isAnonymous) { | ||
| [currentUser deleteWithCompletion:^(NSError * _Nullable error) { |
There was a problem hiding this comment.
Do we no longer need to delete anonymous users?
There was a problem hiding this comment.
We do, I just moved the code to the tableview cell. The reason is that I wanted to use the sign in button to trigger a sign-in when the current user was anonymous. Essentially I am separating anonymous sign in/out with "normal" sign in/out.
|
#403 is now merged, feel free to merge this PR as soon as travis tests pass. Thanks! |
Addresses comments Minor enhances Fixes bug where wrong error is returned
protocol86
force-pushed
the
anonymous_user_upgrade_federated
branch
from
0667df0 to
ba5e708
Compare
protocol86
added a commit
that referenced
this pull request
Jul 17, 2018
* Add anonymous sign in upgrade * Returns merge error in the correct place. * Adds comments and minor changes * Adds correct error handling for linking errors * Addresses comments Addresses comments Minor enhances Fixes bug where wrong error is returned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anonymous user upgrade federated accounts and phone auth.
Swift sample will be updated in a follow up PR.
Addresses #139