Fix tests and disable UI tests #688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 29, 2019
renkelvin
reviewed
May 29, 2019
| [self.auth signInWithCredential:credential | ||
| completion:^(FIRAuthDataResult *_Nullable authResult, | ||
| NSError *_Nullable error) { | ||
| [self.auth signInAndRetrieveDataWithCredential:credential |
There was a problem hiding this comment.
signInAndRetrieveDataWithCredential: is deprecated, see my reply in b/
There was a problem hiding this comment.
Will clean this up--I merged early so other PRs could have passing tests.
renkelvin
reviewed
May 29, 2019
| @@ -153,12 +153,20 @@ | |||
| /* End PBXFrameworksBuildPhase section */ | |||
|
|
|||
| /* Begin PBXGroup section */ | |||
| 7DC88936A359F0A20973DC4C /* Pods */ = { | |||
There was a problem hiding this comment.
These aren't removed by pod deintegrate for some reason. They're not harmful enough to warrant manually removing all of them.
renkelvin
reviewed
May 29, 2019
| @@ -75,6 +75,7 @@ | |||
| 8D69E46021DD8B2E00CFA49B /* FirebaseFirestoreUI */, | |||
| 8D69E46B21DD8B2E00CFA49B /* FirebaseFirestoreUITests */, | |||
| 8D69E45F21DD8B2E00CFA49B /* Products */, | |||
| 905358392FD4EDB2D9802535 /* Pods */, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI tests are currently broken due to underlying changes in Firebase Auth.