feat(auth): Adding tenant-aware token verification support #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiranya911
added a commit
that referenced
this pull request
Sep 8, 2020
* feat(auth): Added TenantManager, Tenant and GetTenantAsync APIs (#222) * feat(auth): Added CreateTenantAsync() and UpdateTenantAsync() APIs (#223) * chore: Introducing FirebaseAdmin.Auth.Jwt namespace for internal APIs (#226) * chore: Introducing FirebaseAdmin.Auth.Jwt namespace for internal APIs * chore: Moving IPublicKeySource and related classes to Jwt * feat(auth): Added ListTenantsAsync() and DeleteTenantAsync() APIs (#225) * feat(auth): Added ListTenantsAsync() and DeleteTenantAsync() APIs * fix: Added newline at eof * feat(auth): Added TenantAwareFirebaseAuth class (#227) * feat(auth): Added support for creating tenant-scoped custom tokens (#228) * feat(auth): Added support for creating tenant-scoped custom tokens * fix: Cleaned up the test code * feat(auth): Support for tenant-aware user management (#229) * feat(auth): Support for tenant-aware user management * fix: Cleaned up the unit tests * fix: Removed duplicated line * feat(auth): Adding tenant-aware token verification support (#230) * feat(auth): Adding tenant-aware token verification support * feat(auth): Moved ID token verify methods to AbstractFirebaseAuth * fix: Cleaned up the unit tests TestConfig API * chore: FirebaseAuth unit test refactor (#231) * chore: Refactoring the test abstraction for Auth * fix: Further cleaned up the AuthTestConfig API * fix: Refactored auth tests with composition of AuthBuilder and MockTokenBuilder * fix: Added some comments; Other readability improvements * fix: Removing redundant else block * feat(auth): Support for verifying tenant-scoped session cookies (#232) * feat(auth): Implemented support for verifying tenant-scoped session cookies * fix: Removing unused test util method * feat(auth): Support for creating tenant-scoped session cookies (#233) * feat(auth): Support for creating tenant-scoped session cookies * fix: Using inheritdoc on the overridden method * feat(auth): Tenant-aware provider config management (#234) * chore: Added FirebaseAdmin.Auth.Users namespace (#235) * chore: More unit tests (#236) * chore: Increased unit test coverage for Auth APIs * chore: More unit tests * fix(auth): Removing tenant-aware session cookie APIs (#237) * chore: Adding integration tests for multi-tenancy support (#238) * chore: Added integration tests for multi-tenancy APIs * fix: Refactored TenantFixture to handle init all test resources * chore: Cleaning up Auth integration tests (#239) * chore: Cleaning up Auth integration tests * fix: Added newline at the eof * chore: Added tenant-aware integ tests for IdP config management (#240) * chore: Added tenant-aware integ tests for IdP config management * chore: Cleaned up the test fixtures * chore: Split long user lifecycle test into multiple test cases (#241) * fix(auth): Reusing ListResourcesRequest util in all pagination APIs (#242) * fix(auth): Reusing ListResourcesRequest for ListUsers API * fix(auth): Using ListResourcesRequest in other list APIs * fix: Enabling AsyncUsageAnalyzers and fixing violations (#243) * fix: Enabling AsyncUsageAnalyzers and fixing violations * fix: Removed experimental changes * fix(auth): Support for verifying tenant ID tokens in FirebaseAuth (#244) * fix: Enabling AsyncUsageAnalyzers and fixing violations * fix: Removed experimental changes * fix(auth): Support for verifying tenant ID tokens in FirebaseAuth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TenantIdfrom theFirebaseTokenclass.VerifyIdTokeAsync()APIs to theAbstractFirebaseAuthclass.LangVersionto latest in theFirebaseAdmin.Tests.csprojfile (we already use the same setting inFirebaseAdmin.csproj). This enables us to use latest language features likeprivate protectedwhich are useful in implementing better encapsulated test utils.