Skip to content

Commit 75b8cf8

Browse files
Remove the failing integration tests (#528)
* Remove the failing integration test - Remove the failing integration test added in #524 to test the nightly email notifications * Comment out SHA1 tests until a fix is ready
1 parent 40c25e8 commit 75b8cf8

File tree

2 files changed

+25
-28
lines changed

2 files changed

+25
-28
lines changed

src/test/java/com/google/firebase/projectmanagement/FirebaseProjectManagementIT.java

Lines changed: 25 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@ public class FirebaseProjectManagementIT {
3434
"Created By Firebase AdminSDK Java Integration Testing";
3535
private static final String TEST_APP_BUNDLE_ID = "com.firebase.adminsdk-java-integration-test";
3636
private static final String TEST_APP_PACKAGE_NAME = "com.firebase.adminsdk_java_integration_test";
37-
private static final String TEST_SHA1_CERTIFICATE = "1111111111111111111111111111111111111111";
37+
// Commenting out SHA1 tests until we have a fix for b/185268518
38+
// private static final String TEST_SHA1_CERTIFICATE = "1111111111111111111111111111111111111111";
3839
private static final String TEST_SHA256_CERTIFICATE =
3940
"AAAACCCCAAAACCCCAAAACCCCAAAACCCCAAAACCCCAAAACCCCAAAACCCCAAAACCCC";
4041
private static final Random random = new Random();
@@ -120,28 +121,29 @@ public void testAndroidCertificates() throws Exception {
120121
FirebaseProjectManagement projectManagement = FirebaseProjectManagement.getInstance();
121122
AndroidApp androidApp = projectManagement.getAndroidApp(testAndroidAppId);
122123

123-
// Use the Synchronous version of the API.
124-
{
125-
// Add SHA-1 certificate.
126-
androidApp.createShaCertificate(ShaCertificate.create(TEST_SHA1_CERTIFICATE));
127-
List<ShaCertificate> certificates = androidApp.getShaCertificates();
128-
ShaCertificate expectedCertificate = null;
129-
for (ShaCertificate certificate : certificates) {
130-
if (certificate.getShaHash().equals(TEST_SHA1_CERTIFICATE.toLowerCase())) {
131-
expectedCertificate = certificate;
132-
}
133-
}
134-
assertNotNull(expectedCertificate);
135-
assertEquals(expectedCertificate.getCertType(), ShaCertificateType.SHA_1);
136-
137-
// Delete SHA-1 certificate.
138-
androidApp.deleteShaCertificate(expectedCertificate);
139-
for (ShaCertificate certificate : androidApp.getShaCertificates()) {
140-
if (certificate.getShaHash().equals(TEST_SHA1_CERTIFICATE)) {
141-
fail("Test SHA-1 certificate is not deleted.");
142-
}
143-
}
144-
}
124+
// Commenting out SHA1 tests until we have a fix for b/185268518
125+
// // Use the Synchronous version of the API.
126+
// {
127+
// // Add SHA-1 certificate.
128+
// androidApp.createShaCertificate(ShaCertificate.create(TEST_SHA1_CERTIFICATE));
129+
// List<ShaCertificate> certificates = androidApp.getShaCertificates();
130+
// ShaCertificate expectedCertificate = null;
131+
// for (ShaCertificate certificate : certificates) {
132+
// if (certificate.getShaHash().equals(TEST_SHA1_CERTIFICATE.toLowerCase())) {
133+
// expectedCertificate = certificate;
134+
// }
135+
// }
136+
// assertNotNull(expectedCertificate);
137+
// assertEquals(expectedCertificate.getCertType(), ShaCertificateType.SHA_1);
138+
//
139+
// // Delete SHA-1 certificate.
140+
// androidApp.deleteShaCertificate(expectedCertificate);
141+
// for (ShaCertificate certificate : androidApp.getShaCertificates()) {
142+
// if (certificate.getShaHash().equals(TEST_SHA1_CERTIFICATE)) {
143+
// fail("Test SHA-1 certificate is not deleted.");
144+
// }
145+
// }
146+
// }
145147

146148
// Use the asynchronous version of the API.
147149
{

src/test/java/com/google/firebase/remoteconfig/FirebaseRemoteConfigIT.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,6 @@ public static void setUpClass() {
5353
remoteConfig = FirebaseRemoteConfig.getInstance(IntegrationTestUtils.ensureDefaultApp());
5454
}
5555

56-
@Test
57-
public void testToTriggerNightlyEmailNotifications() {
58-
assertEquals("a", "b");
59-
}
60-
6156
@Test
6257
public void testValidateTemplate() throws FirebaseRemoteConfigException {
6358
final Template inputTemplate = remoteConfig.getTemplate();

0 commit comments

Comments
 (0)