Remove the failing integration tests #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove the failing integration test added in #524 to test the nightly email notifications Note: staging to trigger integration tests. All tests should pass.
lahirumaramba
changed the title
hiranya911
approved these changes
Apr 21, 2021
| @@ -120,29 +119,6 @@ public void testAndroidCertificates() throws Exception { | |||
| FirebaseProjectManagement projectManagement = FirebaseProjectManagement.getInstance(); | |||
| AndroidApp androidApp = projectManagement.getAndroidApp(testAndroidAppId); | |||
|
|
|||
There was a problem hiding this comment.
Should we just comment out instead of removing?
There was a problem hiding this comment.
Good idea! Let's comment it out for now. Thanks!
lahirumaramba
force-pushed
the
lm-remove-failing-tests
branch
from
6b0ad6e to
ab11354
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: staging to trigger integration tests. All tests should pass.