Porting the legacy integration test suite

pom.xml

@@ -108,22 +108,16 @@
             <version>0.6</version>
             <scope>test</scope>
         </dependency>
-        <dependency>
-            <groupId>org.codehaus.jackson</groupId>
-            <artifactId>jackson-mapper-asl</artifactId>
-            <version>1.9.13</version>
-            <scope>test</scope>
-        </dependency>
         <dependency>
             <groupId>org.hamcrest</groupId>
             <artifactId>hamcrest-library</artifactId>
             <version>1.3</version>
             <scope>test</scope>
         </dependency>
         <dependency>
-            <groupId>com.firebase</groupId>
-            <artifactId>firebase-token-generator</artifactId>
-            <version>2.0.0</version>
+            <groupId>com.cedarsoftware</groupId>
+            <artifactId>java-util</artifactId>
+            <version>1.26.0</version>
             <scope>test</scope>
         </dependency>
         <dependency>

src/test/java/com/google/firebase/FirebaseAppTest.java

@@ -3,6 +3,7 @@
 import static com.google.firebase.internal.Base64Utils.decodeUrlSafeNoPadding;
 import static java.nio.charset.StandardCharsets.UTF_8;
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 import static org.mockito.Mockito.mock;
@@ -35,7 +36,6 @@
 import java.util.concurrent.Callable;
 import java.util.concurrent.TimeUnit;
 import org.junit.Assert;
-import org.junit.Before;
 import org.junit.Rule;
 import org.junit.Test;
 import org.mockito.Mockito;
@@ -55,47 +55,6 @@ public class FirebaseAppTest {
 
   @Rule public FirebaseAppRule firebaseAppRule = new FirebaseAppRule();
 
-  @SuppressWarnings("unused")
-  private static void assertAuthInitialized(FirebaseApp firebaseApp) {
-    // TODO(depoll): Re-enable once Auth is available.
-    // assertThat(FirebaseAuth.getInstancesForTest()).containsKey(firebaseApp
-    // .getPersistenceKey());
-    // FirebaseAuth firebaseAuth = FirebaseAuth.getInstance(firebaseApp);
-    // assertThat(firebaseAuth.getFirebaseApp()).isEqualTo(firebaseApp);
-  }
-
-  private static void assertCrashInitialized() {
-    // TODO(depoll): Re-enable if Crash becomes available.
-    // assertThat(FirebaseCrash.isSingletonInitialized()).isTrue();
-  }
-
-  private static void assertScionInitialized() {
-    // TODO(depoll): Re-enable once Scion becomes available.
-    // assertThat(Scion.getInstanceForTest()).isNotNull();
-  }
-
-  @SuppressWarnings("unused")
-  private static void assertIidInitialized(FirebaseApp firebaseApp) {
-    // TODO(depoll): Re-enable once IID becomes available.
-    // FirebaseInstanceId firebaseInstanceID =
-    //         FirebaseInstanceId.getInstancesForTest()
-    //                 .get(firebaseApp.getOptions().getApplicationId());
-    // assertThat(firebaseInstanceID).isNotNull();
-  }
-
-  // TODO(arondeak): reenable persistence. See b/28158809.
-  //    @Test
-  //    public void testGetApps_persistenceEnabled() {
-  //        FirebaseApp app1 = FirebaseApp.initializeApp(mTargetContext, OPTIONS, "app1");
-  //        FirebaseApp app2 = FirebaseApp.initializeApp(mTargetContext, OPTIONS, "app2");
-  //        FirebaseApp.clearInstancesForTest();
-  //        // Sanity check that instances have been cleared.
-  //        assertThat(FirebaseApp.instances).isEmpty();
-  //        FirebaseApp app3 = FirebaseApp.initializeApp(mTargetContext, OPTIONS, "app3");
-  //        // We rely on FirebaseApp's equals override, app1 and app2 are different instances.
-  //        assertThat(FirebaseApp.getApps(mTargetContext)).containsExactly(app1, app2, app3);
-  //    }
-
   private static void invokePublicInstanceMethodWithDefaultValues(Object instance, Method method)
       throws InvocationTargetException, IllegalAccessException {
     List<Object> parameters = new ArrayList<>(method.getParameterTypes().length);
@@ -105,12 +64,6 @@ private static void invokePublicInstanceMethodWithDefaultValues(Object instance,
     method.invoke(instance, parameters.toArray());
   }
 
-  @Before
-  public void setUp() {
-    // Used by Scion internally.
-    // Scion.testOnlySetDefaultFactory(new ScionFactory(mTargetContext));
-  }
-
   @Test(expected = IllegalStateException.class)
   public void testGetInstancePersistedNotInitialized() {
     String name = "myApp";
@@ -212,24 +165,16 @@ public void testMissingInit() {
   }
 
   @Test
-  public void testAuthInitializedForNonDefaultApp() {
+  public void testApiInitForNonDefaultApp() {
     FirebaseApp firebaseApp = FirebaseApp.initializeApp(OPTIONS, "myApp");
-    assertAuthInitialized(firebaseApp);
-    // Measurement is only initialized for the default app.
-    // TODO(depoll): Re-enable once Scion becomes available.
-    // assertThat(Scion.getInstanceForTest()).isNull();
+    assertFalse(ImplFirebaseTrampolines.isDefaultApp(firebaseApp));
   }
 
   @Test
   public void testApiInitForDefaultApp() {
     // Explicit initialization of FirebaseApp instance.
     FirebaseApp firebaseApp = FirebaseApp.initializeApp(OPTIONS);
-
     assertTrue(ImplFirebaseTrampolines.isDefaultApp(firebaseApp));
-    assertAuthInitialized(firebaseApp);
-    assertCrashInitialized();
-    assertIidInitialized(firebaseApp);
-    assertScionInitialized();
   }
 
   @Test

src/test/java/com/google/firebase/FirebaseOptionsTest.java

@@ -52,6 +52,7 @@ public void onSuccess(GoogleCredential googleCredential) {
   }
 
   @Test
+  @SuppressWarnings("deprecation")
   public void createOptionsWithServiceAccountSet() throws IOException, InterruptedException {
     final Semaphore semaphore = new Semaphore(0);
     FirebaseOptions firebaseOptions =
@@ -115,6 +116,7 @@ public void createOptionsWithCredentialMissing() {
   }
 
   @Test(expected = IllegalStateException.class)
+  @SuppressWarnings("deprecation")
   public void createOptionsWithServiceAccountAndCredential() {
     new FirebaseOptions.Builder()
         .setServiceAccount(ServiceAccount.EDITOR.asStream())

src/test/java/com/google/firebase/auth/FirebaseAuthTest.java

@@ -16,6 +16,7 @@
 import com.google.firebase.FirebaseOptions;
 import com.google.firebase.TestOnlyImplFirebaseTrampolines;
 import com.google.firebase.auth.internal.FirebaseCustomAuthToken;
+import com.google.firebase.database.MapBuilder;
 import com.google.firebase.tasks.Tasks;
 import com.google.firebase.testing.ServiceAccount;
 import com.google.firebase.testing.TestUtils;
@@ -201,7 +202,7 @@ public void testCreateCustomTokenWithDeveloperClaims() throws Exception {
     FirebaseAuth auth = FirebaseAuth.getInstance(app);
 
     String token =
-        Tasks.await(auth.createCustomToken("user1", ImmutableMap.of("claim", (Object) "value")));
+        Tasks.await(auth.createCustomToken("user1", MapBuilder.of("claim", "value")));
 
     FirebaseCustomAuthToken parsedToken = FirebaseCustomAuthToken.parse(new GsonFactory(), token);
     assertEquals(parsedToken.getPayload().getUid(), "user1");

src/test/java/com/google/firebase/auth/FirebaseCredentialsTest.java

@@ -71,7 +71,7 @@ public void defaultCredentialDoesntRefetch() throws Exception {
     Assert.assertEquals(ACCESS_TOKEN, token);
 
     // We should still be able to fetch the token since the certificate is cached
-    credentialsFile.delete();
+    Assert.assertTrue(credentialsFile.delete());
     token =
         Tasks.await(
             FirebaseCredentials.applicationDefault(transport, Utils.getDefaultJsonFactory())

src/test/java/com/google/firebase/auth/TestOnlyImplFirebaseAuthTrampolines.java

@@ -15,8 +15,6 @@
  * Provides trampolines into package-private Auth APIs used by components of Firebase
  *
  * <p>This class will not be compiled into the shipping library and can only be used in tests.
- *
- * @hide
  */
 public final class TestOnlyImplFirebaseAuthTrampolines {
 

src/test/java/com/google/firebase/database/DataSnapshotTest.java

@@ -0,0 +1,77 @@
+package com.google.firebase.database;
+
+import static org.junit.Assert.assertArrayEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
+import com.google.firebase.TestOnlyImplFirebaseTrampolines;
+import com.google.firebase.database.snapshot.IndexedNode;
+import com.google.firebase.database.snapshot.Node;
+import com.google.firebase.database.snapshot.NodeUtilities;
+import java.util.HashMap;
+import java.util.Iterator;
+import org.junit.AfterClass;
+import org.junit.Test;
+
+public class DataSnapshotTest {
+
+  @AfterClass
+  public static void tearDownClass() {
+    TestOnlyImplFirebaseTrampolines.clearInstancesForTest();
+  }
+
+  private DataSnapshot snapFor(Object data) {
+    Node node = NodeUtilities.NodeFromJSON(data);
+    DatabaseReference ref = new DatabaseReference("https://test.firebaseio.com", TestHelpers
+        .newTestConfig());
+    return new DataSnapshot(ref, IndexedNode.from(node));
+  }
+
+  @Test
+  public void testBasicIteration() {
+    DataSnapshot snap1 = snapFor(null);
+
+    assertFalse(snap1.hasChildren());
+    assertFalse(snap1.getChildren().iterator().hasNext());
+
+    DataSnapshot snap2 = snapFor(1L);
+    assertFalse(snap2.hasChildren());
+    assertFalse(snap2.getChildren().iterator().hasNext());
+
+    DataSnapshot snap3 = snapFor(MapBuilder.of("a", 1L, "b", 2L));
+    assertTrue(snap3.hasChildren());
+    Iterator<DataSnapshot> iter = snap3.getChildren().iterator();
+    assertTrue(iter.hasNext());
+
+    String[] children = new String[] {null, null};
+    int i = 0;
+    for (DataSnapshot child : snap3.getChildren()) {
+      children[i] = child.getKey();
+      i++;
+    }
+    assertArrayEquals(children, new String[] {"a", "b"});
+  }
+
+  @Test
+  public void testExists() {
+    DataSnapshot snap;
+
+    snap = snapFor(new HashMap<>());
+    assertFalse(snap.exists());
+
+    snap = snapFor(MapBuilder.of(".priority", 1));
+    assertFalse(snap.exists());
+
+    snap = snapFor(null);
+    assertFalse(snap.exists());
+
+    snap = snapFor(true);
+    assertTrue(snap.exists());
+
+    snap = snapFor(5);
+    assertTrue(snap.exists());
+
+    snap = snapFor(MapBuilder.of("x", 5));
+    assertTrue(snap.exists());
+  }
+}