Skip to content

feat(fcm): Added a Builder for constructing Notification objects #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2019

Conversation

chong-shao
Copy link
Contributor

Add a builder for Notification class.

Mark the existing two constructors for the Notification class as deprecated.
Adjust the tests.

@hiranya911 hiranya911 changed the title Add a builder for Notification feat(fcm): Added a Builder for constructing Notification objects Sep 11, 2019
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chong-shao chong-shao merged commit d6cda02 into master Sep 11, 2019
@chong-shao chong-shao deleted the notification-builder branch September 11, 2019 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants