Skip to content

feat(fcm): Add 12 new android notification params support #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Oct 29, 2019
Merged

feat(fcm): Add 12 new android notification params support #320

merged 15 commits into from
Oct 29, 2019

Conversation

chong-shao
Copy link
Contributor

@chong-shao chong-shao commented Oct 17, 2019 •
edited by hiranya911
Loading

Add 12 new android notification params support

Testing

  • Added unit tests to reflect this change.

API Changes

  • In Firebase Cloud Messaging, added new fields in AndroidNotification class.

RELEASE NOTE: Added a series of new parameters to the AndroidNotification class that allow further customization of notifications that target Android devices.

@chong-shao chong-shao requested a review from hiranya911 October 17, 2019 03:07
@lahirumaramba
Copy link
Member

Thanks @chong-shao!
Did we decide not to include DefaultLightSettings parameter in the Java API?

@chong-shao
Copy link
Contributor Author

Opps I forgot to add DefaultLightSettings .. We should include it. Will add it soon

@chong-shao
Copy link
Contributor Author

Added DefaultLightSettings.

hiranya911
hiranya911 suggested changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good. Make sure the public APIs accept primitives whenever possible. And I thought some of the builders were slightly overkill.

@hiranya911 hiranya911 assigned chong-shao and unassigned hiranya911 Oct 17, 2019
hiranya911
hiranya911 suggested changes Oct 19, 2019
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. This is very close to being done. Just a few nits to address.

hiranya911
hiranya911 suggested changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks pretty good. Just a last couple of nits.

@hiranya911 hiranya911 requested a review from egilmorez October 21, 2019 22:10
@hiranya911
Copy link
Contributor

@egilmorez please take a look at the API doc components of this PR.

hiranya911
hiranya911 approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please wait for @lahirumaramba and @egilmorez to make a pass.

lahirumaramba
lahirumaramba approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lahirumaramba
lahirumaramba reviewed Oct 22, 2019
View reviewed changes
egilmorez
egilmorez reviewed Oct 22, 2019
View reviewed changes
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggests for you Chong.

Thanks!

@lahirumaramba lahirumaramba removed their assignment Oct 22, 2019
egilmorez
egilmorez approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG Chong, thanks!

(I should have know that backticks don't work in Javadoc :) )

hiranya911
hiranya911 suggested changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment about setter names. Then we can merge.

hiranya911
hiranya911 approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

@chong-shao
Parse timestamp with a timezone 'Z' so that in the MessageTest, the e…
0c5e8bb 
…xpected value of eventTime does not depend on the machine's local timezone.
@chong-shao chong-shao merged commit a8f5ba8 into master Oct 29, 2019
@chong-shao chong-shao deleted the 12-new-android-notification-params branch October 29, 2019 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

@hiranya911 hiranya911 hiranya911 approved these changes

@egilmorez egilmorez egilmorez approved these changes

Assignees

@chong-shao chong-shao

Labels
release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chong-shao @lahirumaramba @hiranya911 @egilmorez