Fix a typo in AndroidNotification #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chong-shao
requested changes
Oct 29, 2019
| @@ -443,7 +443,7 @@ public Builder setSticky(boolean sticky) { | |||
| /** | |||
| * For notifications that inform users about events with an absolute time reference, sets | |||
| * the time that the event in the notification occurred in milliseconds. Notifications | |||
| * in the panel are sorted by this time. The time is be formated in RFC3339 UTC "Zulu" | |||
| * in the panel are sorted by this time. The time will be formatted in RFC3339 UTC "Zulu" | |||
There was a problem hiding this comment.
Good catch and thanks for doing this! Could you change it to "is formatted"? egilmore@ looked at this before and suggested to avoid "will."
There was a problem hiding this comment.
Thanks, Chong. Updated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AndroidNotification