Skip to content

Fix documentation strings in Android Notification #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2020
Merged

Conversation

lahirumaramba
Copy link
Member

@lahirumaramba lahirumaramba commented Jun 17, 2020

  • Fix documentation strings
  • Bye bye, will :)

Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lahiru!

Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit.

@@ -207,7 +207,7 @@ public Builder setFcmOptions(AndroidFcmOptions androidFcmOptions) {
}

/**
* Sets the direct_boot_ok flag, If set to true, messages will be allowed to be delivered to
* Sets the {@code direct_boot_ok} flag, If set to true, messages are delivered to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flag. If set to...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks!

@lahirumaramba lahirumaramba merged commit f938b3b into master Jun 19, 2020
@lahirumaramba lahirumaramba deleted the lm-fix-docs branch June 19, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants