Skip to content

Drop 500 from the retryable errorcode list #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Conversation

chong-shao
Copy link
Contributor

Google Cloud documentation has been updated to not consider 500 as a retryable error code. Update Admin SDK to align with that

Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pleasantly surprised that this didn't break more unit tests :)

LGTM 👍

@chong-shao
Copy link
Contributor Author

Thanks!

@chong-shao chong-shao merged commit 49c3f58 into master Jun 28, 2021
@chong-shao chong-shao deleted the change_on_retry branch June 28, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants