Implementing Phone Auth Support #60
Conversation
|
Related to #56 |
| // Phone number verification is very lax here. Backend will enforce E.164 spec compliance, and | ||
| // normalize accordingly. | ||
| checkArgument(!Strings.isNullOrEmpty(phoneNumber), "phone number cannot be null or empty"); | ||
| checkState(phoneNumber.matches("^\\+.*[a-zA-Z0-9].*$"), |
There was a problem hiding this comment.
If I read this correctly, this merely verifies that the phone number starts with '+' and contains at least one 'normal' character. So +&&&a&&& might be a valid number? If that is our level of verification, then we might as well let the server handles it.
There was a problem hiding this comment.
I simplified this to check only for the + prefix. Updated the error message accordingly. We can rely on the backend server for more comprehensive validation of phone numbers.
| * | ||
| * @param phone a valid phone number string or null. | ||
| */ | ||
| public UpdateRequest setPhoneNumber(String phone) { |
There was a problem hiding this comment.
Do we not want to use Nullable here? (and everywhere else).
I feel we shouldn't be calling this out in our comments but rather in our code. Furthermore, it is not clear from the comment what setting the number to 'null' entails.
There was a problem hiding this comment.
Done. Added Nullable to appropriate method arguments, and also updated the javadoc of setPhoneNumber().
|
Made the suggested changes. |
FirebaseAuth.getUserByPhoneNumber()method.setPhoneNumber()method toCreateRequestandUpdateRequesttypes.UserInfoandUserRecordtypes.go/firebase-java-phone-auth