Adding a Set of New Unit Tests #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
approved these changes
Nov 9, 2017
| assertTrue(error.getMessage().contains("_test_")); | ||
| assertEquals("", error.getDetails()); | ||
|
|
||
| try { |
There was a problem hiding this comment.
This block is the same as above. I suggest to remove this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of a series of PRs I'm working on to improve the unit test coverage of the Java Admin SDK. This adds new unit tests to several packages (mostly RTDB-related), and also removes some of the dead code in the repo.
There are no implementation changes in this PR other than the removal of the dead code. This boosts the code coverage from 55% to 67%.