Refactored the HTTP Client Implementation #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-node into hkj-http-cleanup
bojeil-google
suggested changes
Apr 19, 2019
src/utils/api-request.ts
Outdated
| } | ||
| reject(enhanceError(err, config, null, req)); | ||
| }); | ||
| constructor(config: HttpRequestConfig) { |
There was a problem hiding this comment.
You may want to declare this as private since it is pretty much only initialized from within the static method.
There was a problem hiding this comment.
Good call. Done.
src/utils/api-request.ts
Outdated
| throw new Error('Request data must be a string, a Buffer or a json serializable object'); | ||
| } | ||
|
|
||
| // Add Content-Length header if data exists |
|
Thanks @bojeil-google. I've made the suggested changes. |
bojeil-google
approved these changes
Apr 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code has become rather long and complex over the months. Therefore I'm refactoring it to make the code more modular and easier to follow:
AsyncHttpCallclass to handle a single HTTP interaction.sendRequest()method has been broken down into a bunch of smaller methods, and moved intoAsyncHttpCall.