-
Notifications
You must be signed in to change notification settings - Fork 396
add environment variable to point admin sdk at rtdb emulator #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Abandoned and replaced by #596 |
I think we need to re-open this PR and discuss using fake credentials for the emulators. Right now we're requiring developers to either do this themselves, or use a real production service account credential. |
* set `databaseURL` in FirebaseAppOptions. The varaible should be a complete | ||
* URI specifying a transfer protocol, hostname, and port number: | ||
* | ||
* FIREBASE_DATABASE_EMULATOR_HOST=http://localhost:9000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I am not mistaken, the protocol is omitted in FIRESTORE_EMULATOR_HOST. I see that it might make sense to include it here (since we need to include the namespace). Should we come up with a consistent pattern that apploes to both RTDB and Firestore? @ryanpbrewster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the protocol should not be included in the FIRESTORE_EMULATOR_HOST
variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we care about the consistency between FIRESTORE_EMULATOR_HOST and FIREBASE_DATABASE_EMULATOR_HOST?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, ideally neither should include the protocol.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is dated, neither emulator host variable has a protocol.
I totally agree with reopening this, or at least reverting #602 I am wondering how a new feature in the Firebase JS SDK is sufficient for the firebase-admin Node SDK? For example, I am using firebase-admin with firebase-functions and I do not touch the firebase JS client SDK and having this in the admin SDK would be really appreciated. The only weird thing I found is that if I run the emulators using emulators:start and manually invoke the functions it seems to work, but if I try to automate the steps using emulators:exec it doesn't work. |
@dungahk can you open a new issue on the |
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.