Migrate Project Config service calls to v2. #665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrsim
force-pushed
the
projectconfig-version
branch
from
2e9a822 to
fdaa025
Compare
bojeil-google
suggested changes
Oct 9, 2019
| @@ -2515,7 +2515,7 @@ AUTH_REQUEST_HANDLER_TESTS.forEach((handler) => { | |||
|
|
|||
| describe('getOAuthIdpConfig()', () => { | |||
| const providerId = 'oidc.provider'; | |||
| const path = handler.path('v2beta1', `/oauthIdpConfigs/${providerId}`, 'project_id'); | |||
There was a problem hiding this comment.
We also want to rename the APIs to be consistent with the SAML counterparts here and elsewhere.
oauthIdpConfigs -> inboundOauthConfigs
Check the proto file for confirmation.
There was a problem hiding this comment.
Seems like oauthIdpConfigs was kept for OnePlatform compliancy.
src/auth/auth-api-request.ts
Outdated
| @@ -1644,7 +1644,7 @@ export class TenantAwareAuthRequestHandler extends AbstractAuthRequestHandler { | |||
| * @return {AuthResourceUrlBuilder} A new project config resource URL builder instance. | |||
| */ | |||
| protected newProjectConfigUrlBuilder(): AuthResourceUrlBuilder { | |||
| return new TenantAwareAuthResourceUrlBuilder(this.projectId, 'v2beta1', this.tenantId); | |||
| return new TenantAwareAuthResourceUrlBuilder(this.projectId, 'admin/v2', this.tenantId); | |||
There was a problem hiding this comment.
It seems they plan to remove the admin/ prefix as it is not one platform compliant (it will break the API discovery doc).
They are working on it now.
There was a problem hiding this comment.
Removed the prefix from the calls.
bojeil-google
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.