-
Notifications
You must be signed in to change notification settings - Fork 397
Add null to databaseAuthVariableOverride #926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It makes sense to me. I am adding @rsgowman for his input as the I think you are right. We probably should use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks right to me; I'm sure I just missed adding the | null
when I did that earlier PR. (Thanks!)
Re Object vs object: I also agree that we should be using object
. It's a real easy mistake to make; I certainly didn't notice the discrepancy when working on #676 and it's a safe bet that the original author (and reviewer) didn't intend for this difference either.
I don't know the implications re api change though. It's worth running that by Hiranya. Either way, I'd lean towards submitting this as is and doing a separate PR for the s/Object/object change. (Lahiru, I'll let you and Hiranya work out the best path forward for that.)
Thank you, @rsgowman ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @MathBunny! LGTM!
@schmidt-sebastian can you also take a quick look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @schmidt-sebastian - will merge this now and then will discuss with Hiranya and Lahiru next steps for the |
I noticed that the
databaseAuthVariableOverride
does not accept null in the source:firebase-admin-node/src/firebase-app.ts
Lines 48 to 56 in 488f931
Meanwhile, in typings it accepts null:
firebase-admin-node/src/index.d.ts
Lines 138 to 163 in 488f931
Another observation is
object
vsObject
discrepancy, from my understandingobject
is generally preferred but I don't know if it's safe or worth changing the typings for this.