Skip to content

fix(fcm): String representation in Message class #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 25, 2019
Merged

fix(fcm): String representation in Message class #350

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fbe4b3
String representation in Message class
lahirumaramba Sep 23, 2019
588a1fb
PR fixes and add test cases
lahirumaramba Sep 24, 2019
317e4b3
Fix pylint errors
lahirumaramba Sep 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions firebase_admin/_messaging_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ def __init__(self, data=None, notification=None, android=None, webpush=None, apn
self.topic = topic
self.condition = condition

def __str__(self):
return json.dumps(MessageEncoder().default(self))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this work?

json.dumps(self, cls=MessageEncoder)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Thank you.
Will update with test cases soon.



class MulticastMessage(object):
"""A message that can be sent to multiple tokens via Firebase Cloud Messaging.
Expand Down