Skip to content

Fix send_all & send_multicast snippet comment to match implementation #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 30, 2020

Conversation

alihen
Copy link
Contributor

@alihen alihen commented Dec 20, 2019

Discussion

While #362 increased the messaging.send_all() and messaging.send_multicast() limit to 500 in (which was released v3.2.0), the snippet comment was not updated.

This PR updates the snippet comment as it's useful for users that are getting started with the SDK and haven't read previous release notes.

@alihen alihen changed the title Fix send_all comment Fix send_all snippet comment to match implementation Dec 20, 2019
@alihen alihen changed the title Fix send_all snippet comment to match implementation Fix send_all & send_multicast snippet comment to match implementation Dec 20, 2019
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiranya911 hiranya911 self-assigned this Jan 29, 2020
@hiranya911 hiranya911 merged commit 04e2b1b into firebase:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants