Skip to content

chore: Cleaning up scripts used in the old release process #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2020
Merged

chore: Cleaning up scripts used in the old release process #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Continuous Integration

on: push
on: pull_request
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need both push and pull_request events to trigger CI if we make changes to a PR based on reviews?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pull_request events are triggered on open, synchronize and reopen sub events. synchronize sub event covers the case we need.


jobs:
build:
Expand Down
4 changes: 2 additions & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
build/
dist/
*~
scripts/cert.json
scripts/apikey.txt
cert.json
apikey.txt
htmlcov/
.pytest_cache/
.vscode/
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,9 @@ following credentials from the project:

1. *Service account certificate*: This can be downloaded as a JSON file from
the "Settings > Service Accounts" tab of the Firebase console. Copy the
file into the repo so it's available at `scripts/cert.json`.
file into the repo so it's available at `cert.json`.
2. *Web API key*: This is displayed in the "Settings > General" tab of the
console. Copy it and save to a new text file at `scripts/apikey.txt`.
console. Copy it and save to a new text file at `apikey.txt`.

Then set up your Firebase/GCP project as follows:

Expand Down Expand Up @@ -202,7 +202,7 @@ Then set up your Firebase/GCP project as follows:
Now you can invoke the integration test suite as follows:

```
pytest integration/ --cert scripts/cert.json --apikey scripts/apikey.txt
pytest integration/ --cert cert.json --apikey apikey.txt
```

### Emulator-based Integration Testing
Expand Down
25 changes: 0 additions & 25 deletions scripts/bash_utils.sh
View file
Open in desktop

This file was deleted.

140 changes: 0 additions & 140 deletions scripts/prepare_release.sh
View file
Open in desktop

This file was deleted.

45 changes: 0 additions & 45 deletions scripts/verify_release.sh
View file
Open in desktop

This file was deleted.