Skip to content

fix(fcm): Updated topic management error format #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2020
Merged

Conversation

hiranya911
Copy link
Contributor

Current error handling logic assumes topic management error responses contain an error message. In reality they only contain an error code. This PR updates the implementation to handle these responses correctly.

RELEASE NOTE: Returning more descriptive error messages from the topic management APIs.

Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hiranya911 hiranya911 merged commit 69c940c into master Feb 27, 2020
@hiranya911 hiranya911 deleted the hkj-topic-mgt branch February 27, 2020 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants