Skip to content

Commit 0784d9c

Browse files
argzdevrlazo
andauthored
issue_3321_seperate_firebaseapp (#3327)
* issue_3321_seperate_firebaseapp * fix formatting * Update firebase-ml-modeldownloader/src/main/java/com/google/firebase/ml/modeldownloader/internal/ModelFileManager.java Co-authored-by: Rodrigo Lazo <[email protected]> * Update firebase-ml-modeldownloader/src/main/java/com/google/firebase/ml/modeldownloader/internal/ModelFileManager.java Co-authored-by: Rodrigo Lazo <[email protected]> * Update firebase-ml-modeldownloader/src/main/java/com/google/firebase/ml/modeldownloader/internal/FirebaseMlLogger.java Co-authored-by: Rodrigo Lazo <[email protected]> * Update firebase-ml-modeldownloader/src/main/java/com/google/firebase/ml/modeldownloader/internal/FirebaseMlLogger.java Co-authored-by: Rodrigo Lazo <[email protected]> * Changed app.getName to app.get Co-authored-by: Rodrigo Lazo <[email protected]>
1 parent 579a83e commit 0784d9c

File tree

4 files changed

+12
-2
lines changed

4 files changed

+12
-2
lines changed

firebase-ml-modeldownloader/src/main/java/com/google/firebase/ml/modeldownloader/FirebaseModelDownloader.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public class FirebaseModelDownloader {
5555
FirebaseApp firebaseApp, FirebaseInstallationsApi firebaseInstallationsApi) {
5656
this.firebaseOptions = firebaseApp.getOptions();
5757
this.sharedPreferencesUtil = new SharedPreferencesUtil(firebaseApp);
58-
this.eventLogger = FirebaseMlLogger.getInstance();
58+
this.eventLogger = FirebaseMlLogger.getInstance(firebaseApp);
5959
this.fileDownloadService = new ModelFileDownloadService(firebaseApp);
6060
this.modelDownloadService =
6161
new CustomModelDownloadService(firebaseApp, firebaseInstallationsApi);

firebase-ml-modeldownloader/src/main/java/com/google/firebase/ml/modeldownloader/internal/FirebaseMlLogger.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,11 @@ public static FirebaseMlLogger getInstance() {
9393
return FirebaseApp.getInstance().get(FirebaseMlLogger.class);
9494
}
9595

96+
@NonNull
97+
public static FirebaseMlLogger getInstance(@NonNull FirebaseApp app) {
98+
return app.get(FirebaseMlLogger.class);
99+
}
100+
96101
void logModelInfoRetrieverFailure(CustomModel model, ErrorCode errorCode) {
97102
logModelInfoRetrieverFailure(model, errorCode, NO_FAILURE_VALUE);
98103
}

firebase-ml-modeldownloader/src/main/java/com/google/firebase/ml/modeldownloader/internal/ModelFileDownloadService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ public class ModelFileDownloadService {
8585
public ModelFileDownloadService(@NonNull FirebaseApp firebaseApp) {
8686
this.context = firebaseApp.getApplicationContext();
8787
downloadManager = (DownloadManager) context.getSystemService(Context.DOWNLOAD_SERVICE);
88-
this.fileManager = ModelFileManager.getInstance();
88+
this.fileManager = ModelFileManager.getInstance(firebaseApp);
8989
this.sharedPreferencesUtil = new SharedPreferencesUtil(firebaseApp);
9090
this.isInitialLoad = true;
9191
this.eventLogger = FirebaseMlLogger.getInstance();

firebase-ml-modeldownloader/src/main/java/com/google/firebase/ml/modeldownloader/internal/ModelFileManager.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,11 @@ public static ModelFileManager getInstance() {
6262
return FirebaseApp.getInstance().get(ModelFileManager.class);
6363
}
6464

65+
@NonNull
66+
public static ModelFileManager getInstance(@NonNull FirebaseApp app) {
67+
return app.get(ModelFileManager.class);
68+
}
69+
6570
void deleteNonLatestCustomModels() throws FirebaseMlException {
6671
File root = getDirImpl("");
6772

0 commit comments

Comments
 (0)