issue_3321_seperate_firebaseapp #3327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report 1Affected Products
Test Logs
Notes |
Size Report 1Affected Products
Test Logs
Notes |
rlazo
reviewed
Jan 22, 2022
...wnloader/src/main/java/com/google/firebase/ml/modeldownloader/internal/ModelFileManager.java
Outdated
Show resolved
Hide resolved
...wnloader/src/main/java/com/google/firebase/ml/modeldownloader/internal/ModelFileManager.java
Outdated
Show resolved
Hide resolved
...wnloader/src/main/java/com/google/firebase/ml/modeldownloader/internal/FirebaseMlLogger.java
Outdated
Show resolved
Hide resolved
...wnloader/src/main/java/com/google/firebase/ml/modeldownloader/internal/FirebaseMlLogger.java
Outdated
Show resolved
Hide resolved
…ml/modeldownloader/internal/ModelFileManager.java Co-authored-by: Rodrigo Lazo <[email protected]>
…ml/modeldownloader/internal/ModelFileManager.java Co-authored-by: Rodrigo Lazo <[email protected]>
…ml/modeldownloader/internal/FirebaseMlLogger.java Co-authored-by: Rodrigo Lazo <[email protected]>
…ml/modeldownloader/internal/FirebaseMlLogger.java Co-authored-by: Rodrigo Lazo <[email protected]>
rlazo
reviewed
Jan 25, 2022
...wnloader/src/main/java/com/google/firebase/ml/modeldownloader/internal/ModelFileManager.java
Outdated
Show resolved
Hide resolved
rlazo
approved these changes
Jan 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #3321 by dev-gloomyfox.
TLDR: FirebaseModelDownloader instance creation fails when using a separate FirebaseApp instance.
The proposed fix will overload the
getInstancemethod of bothFirebaseMlLogger.java&ModelFileManager.java. This method will have a parameter ofFirebaseApp, and will be used in FirebaseModelDownloader.java#L58 & ModelFileDownloadService.java#L88.More details is explained by the developer in the said issue.