Skip to content

Commit 13eae6b

Browse files
authored
Merge d14c057 into c63bc13
2 parents c63bc13 + d14c057 commit 13eae6b

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

firebase-sessions/firebase-sessions.gradle.kts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,13 @@ android {
4242
}
4343

4444
dependencies {
45+
implementation("androidx.datastore:datastore-preferences:1.0.0")
46+
implementation("com.google.android.datatransport:transport-api:3.0.0")
4547
implementation("com.google.firebase:firebase-common-ktx:20.3.2")
4648
implementation("com.google.firebase:firebase-components:17.1.0")
4749
implementation("com.google.firebase:firebase-encoders-json:18.0.1")
4850
implementation("com.google.firebase:firebase-encoders:17.0.0")
4951
implementation("com.google.firebase:firebase-installations-interop:17.1.0")
50-
implementation("com.google.android.datatransport:transport-api:3.0.0")
51-
implementation ("androidx.datastore:datastore-preferences:1.0.0")
5252
implementation(libs.androidx.annotation)
5353

5454
runtimeOnly("com.google.firebase:firebase-installations:17.1.3")
@@ -60,6 +60,7 @@ dependencies {
6060
testImplementation(libs.kotlin.coroutines.test)
6161
testImplementation(libs.robolectric)
6262
testImplementation(libs.truth)
63+
testImplementation(project(":integ-testing"))
6364

6465
androidTestImplementation(libs.androidx.test.junit)
6566
androidTestImplementation(libs.androidx.test.runner)

firebase-sessions/src/main/kotlin/com/google/firebase/sessions/SessionCoordinator.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ package com.google.firebase.sessions
1818

1919
import android.util.Log
2020
import com.google.firebase.installations.FirebaseInstallationsApi
21-
import kotlinx.coroutines.CoroutineDispatcher
21+
import kotlin.coroutines.CoroutineContext
2222
import kotlinx.coroutines.CoroutineScope
2323
import kotlinx.coroutines.launch
2424
import kotlinx.coroutines.tasks.await
@@ -31,10 +31,10 @@ import kotlinx.coroutines.tasks.await
3131
*/
3232
internal class SessionCoordinator(
3333
private val firebaseInstallations: FirebaseInstallationsApi,
34-
backgroundDispatcher: CoroutineDispatcher,
34+
context: CoroutineContext,
3535
private val eventGDTLogger: EventGDTLoggerInterface,
3636
) {
37-
private val scope = CoroutineScope(backgroundDispatcher)
37+
private val scope = CoroutineScope(context)
3838

3939
fun attemptLoggingSessionEvent(sessionEvent: SessionEvent) =
4040
scope.launch {

firebase-sessions/src/test/kotlin/com/google/firebase/sessions/SessionCoordinatorTest.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,15 @@ package com.google.firebase.sessions
1919
import androidx.test.ext.junit.runners.AndroidJUnit4
2020
import com.google.common.truth.Truth.assertThat
2121
import com.google.firebase.FirebaseApp
22+
import com.google.firebase.concurrent.TestOnlyExecutors
2223
import com.google.firebase.sessions.settings.SessionsSettings
2324
import com.google.firebase.sessions.testing.FakeEventGDTLogger
2425
import com.google.firebase.sessions.testing.FakeFirebaseApp
2526
import com.google.firebase.sessions.testing.FakeFirebaseInstallations
2627
import com.google.firebase.sessions.testing.FakeTimeProvider
2728
import com.google.firebase.sessions.testing.TestSessionEventData
2829
import kotlinx.coroutines.ExperimentalCoroutinesApi
29-
import kotlinx.coroutines.test.StandardTestDispatcher
30+
import kotlinx.coroutines.asCoroutineDispatcher
3031
import kotlinx.coroutines.test.runCurrent
3132
import kotlinx.coroutines.test.runTest
3233
import org.junit.After
@@ -42,7 +43,7 @@ class SessionCoordinatorTest {
4243
val sessionCoordinator =
4344
SessionCoordinator(
4445
firebaseInstallations = FakeFirebaseInstallations("FaKeFiD"),
45-
backgroundDispatcher = StandardTestDispatcher(testScheduler),
46+
context = TestOnlyExecutors.background().asCoroutineDispatcher() + coroutineContext,
4647
eventGDTLogger = fakeEventGDTLogger,
4748
)
4849

0 commit comments

Comments
 (0)