Skip to content

Commit c63bc13

Browse files
authored
Make logging consistent with Apple SDK (#4919)
1 parent 5402c30 commit c63bc13

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

firebase-sessions/src/main/kotlin/com/google/firebase/sessions/EventGDTLogger.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ internal class EventGDTLogger(private val transportFactoryProvider: Provider<Tra
5555

5656
private fun encode(value: SessionEvent): ByteArray {
5757
val jsonEvent = SessionEvents.SESSION_EVENT_ENCODER.encode(value)
58-
Log.d(TAG, "Encoded Session Start event $jsonEvent")
58+
Log.d(TAG, "Session Event: $jsonEvent")
5959
return jsonEvent.toByteArray()
6060
}
6161

firebase-sessions/src/main/kotlin/com/google/firebase/sessions/FirebaseSessions.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ internal constructor(
4949
if (appContext is Application) {
5050
appContext.registerActivityLifecycleCallbacks(sessionInitiator.activityLifecycleCallbacks)
5151
} else {
52-
Log.w(
52+
Log.e(
5353
TAG,
5454
"Failed to register lifecycle callbacks, unexpected context ${appContext.javaClass}."
5555
)

firebase-sessions/src/main/kotlin/com/google/firebase/sessions/SessionCoordinator.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,17 +42,17 @@ internal class SessionCoordinator(
4242
try {
4343
firebaseInstallations.id.await()
4444
} catch (ex: Exception) {
45-
Log.w(TAG, "Session Installations Error", ex)
45+
Log.e(TAG, "Error getting Firebase Installation ID: ${ex}. Using an empty ID")
4646
// Use an empty fid if there is any failure.
4747
""
4848
}
4949

5050
try {
5151
eventGDTLogger.log(sessionEvent)
5252

53-
Log.i(TAG, "Logged Session Start event: ${sessionEvent.sessionData.sessionId}")
53+
Log.i(TAG, "Successfully logged Session Start event: ${sessionEvent.sessionData.sessionId}")
5454
} catch (e: RuntimeException) {
55-
Log.w(TAG, "Failed to log Session Start event: ", e)
55+
Log.e(TAG, "Error logging Session Start event to DataTransport: ", e)
5656
}
5757
}
5858

0 commit comments

Comments
 (0)