Skip to content

Make Sessions logging consistent with Apple SDK #4919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2023
Merged

Make Sessions logging consistent with Apple SDK #4919

merged 1 commit into from
Apr 21, 2023

Conversation

samedson
Copy link
Contributor

No description provided.

@samedson samedson requested review from visumickey and mrober and removed request for visumickey April 20, 2023 19:32
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (b0bea40) to 64.98% (e36e98f) by ?.

    14 individual files with coverage change

    FilenameBase (b0bea40)Merge (e36e98f)Diff
    ApplicationInfo.kt?100.00%?
    EventGDTLogger.kt?75.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsEarly.kt?0.00%?
    FirebaseSessionsRegistrar.kt?0.00%?
    LocalOverrideSettings.kt?90.00%?
    SessionCoordinator.kt?76.47%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?100.00%?
    SessionGenerator.kt?22.73%?
    SessionInitiator.kt?66.67%?
    SessionsSettings.kt?84.62%?
    SettingsProvider.kt?0.00%?
    Time.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ac5RfXBcAn.html

@github-actions
Copy link
Contributor

Unit Test Results

18 files  18 suites   27s ⏱️
23 tests 23 ✔️ 0 💤 0 ❌
46 runs  46 ✔️ 0 💤 0 ❌

Results for commit 3e6be97.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (b0bea40)Merge (e36e98f)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)

  • firebase-datatransport

    TypeBase (b0bea40)Merge (e36e98f)Diff
    aar?4.94 kB? (?)
    apk (aggressive)?161 kB? (?)
    apk (release)?1.35 MB? (?)

  • firebase-sessions

    TypeBase (b0bea40)Merge (e36e98f)Diff
    aar?48.3 kB? (?)
    apk (aggressive)?251 kB? (?)
    apk (release)?1.77 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/2n0Atl0whD.html

@samedson samedson merged commit c63bc13 into firebase-sessions Apr 21, 2023
@samedson samedson deleted the sessions-logging branch April 21, 2023 15:37
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@visumickey visumickey visumickey approved these changes

@mrober mrober mrober approved these changes

Assignees
No one assigned
Labels
api: sessions size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samedson @google-oss-bot @visumickey @mrober