Skip to content

Commit 22c314f

Browse files
ehsannasmilaGGL
andauthored
Clean up and re-enable OR query integration tests. (#5346)
Co-authored-by: Mila <[email protected]>
1 parent dd56689 commit 22c314f

File tree

1 file changed

+0
-36
lines changed
  • firebase-firestore/src/androidTest/java/com/google/firebase/firestore

1 file changed

+0
-36
lines changed

firebase-firestore/src/androidTest/java/com/google/firebase/firestore/QueryTest.java

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -1579,29 +1579,6 @@ public void testOrQueriesWithIn() {
15791579
collection.where(or(equalTo("a", 2), inArray("b", asList(2, 3)))), "doc3", "doc4", "doc6");
15801580
}
15811581

1582-
@Test
1583-
public void testOrQueriesWithNotIn() {
1584-
assumeTrue(
1585-
"Skip this test if running against production because it results in a "
1586-
+ "'missing index' error. The Firestore Emulator, however, does serve these "
1587-
+ " queries",
1588-
isRunningAgainstEmulator());
1589-
Map<String, Map<String, Object>> testDocs =
1590-
map(
1591-
"doc1", map("a", 1, "b", 0),
1592-
"doc2", map("b", 1),
1593-
"doc3", map("a", 3, "b", 2),
1594-
"doc4", map("a", 1, "b", 3),
1595-
"doc5", map("a", 1),
1596-
"doc6", map("a", 2));
1597-
CollectionReference collection = testCollectionWithDocs(testDocs);
1598-
1599-
// a==2 || b not-in [2,3]
1600-
// Has implicit orderBy b.
1601-
checkOnlineAndOfflineResultsMatch(
1602-
collection.where(or(equalTo("a", 2), notInArray("b", asList(2, 3)))), "doc1", "doc2");
1603-
}
1604-
16051582
@Test
16061583
public void testOrQueriesWithArrayMembership() {
16071584
Map<String, Map<String, Object>> testDocs =
@@ -1628,10 +1605,6 @@ public void testOrQueriesWithArrayMembership() {
16281605

16291606
@Test
16301607
public void testMultipleInOps() {
1631-
// TODO(orquery): Enable this test against production when possible.
1632-
assumeTrue(
1633-
"Skip this test if running against production because it's not yet supported.",
1634-
isRunningAgainstEmulator());
16351608
Map<String, Map<String, Object>> testDocs =
16361609
map(
16371610
"doc1", map("a", 1, "b", 0),
@@ -1654,10 +1627,6 @@ public void testMultipleInOps() {
16541627

16551628
@Test
16561629
public void testUsingInWithArrayContainsAny() {
1657-
// TODO(orquery): Enable this test against production when possible.
1658-
assumeTrue(
1659-
"Skip this test if running against production because it's not yet supported.",
1660-
isRunningAgainstEmulator());
16611630
Map<String, Map<String, Object>> testDocs =
16621631
map(
16631632
"doc1", map("a", 1, "b", asList(0)),
@@ -1711,11 +1680,6 @@ public void testUsingInWithArrayContains() {
17111680

17121681
@Test
17131682
public void testOrderByEquality() {
1714-
// TODO(orquery): Enable this test against production when possible.
1715-
assumeTrue(
1716-
"Skip this test if running against production because order-by-equality is "
1717-
+ "not supported yet.",
1718-
isRunningAgainstEmulator());
17191683
Map<String, Map<String, Object>> testDocs =
17201684
map(
17211685
"doc1", map("a", 1, "b", asList(0)),

0 commit comments

Comments
 (0)