Skip to content

Clean up and re-enable OR query integration tests. #5346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

ehsannas
Copy link
Contributor

No description provided.

@ehsannas ehsannas self-assigned this Sep 19, 2023
@github-actions
Copy link
Contributor

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 19, 2023

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 44.75% (dd56689) to 44.74% (2d11a3a) by -0.01%.

    FilenameBase (dd56689)Merge (2d11a3a)Diff
    DeleteMutation.java95.24%90.48%-4.76%
    LruGarbageCollector.java97.27%93.64%-3.64%
    PatchMutation.java98.39%100.00%+1.61%
    SetMutation.java94.44%97.22%+2.78%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/WkhJkyx1Qx.html

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2023

Unit Test Results

   180 files  ±0     180 suites  ±0   2m 42s ⏱️ +17s
1 220 tests ±0  1 204 ✔️ ±0  16 💤 ±0  0 ±0 
2 464 runs  ±0  2 432 ✔️ ±0  32 💤 ±0  0 ±0 

Results for commit 39c8bf9. ± Comparison against base commit dd56689.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 19, 2023

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 19, 2023

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fst

    DeviceStatisticsDistributions
    oriole-32
    Percentiledd566892d11a3aDiffSignificant (?)
    p10326 ±29 μs314 ±15 μs-11.2 μs (-3.5%)NO
    p25340 ±36 μs326 ±20 μs-14.0 μs (-4.1%)NO
    p50368 ±55 μs353 ±48 μs-14.3 μs (-3.9%)NO
    p75424 ±77 μs414 ±98 μs-9.17 μs (-2.2%)NO
    p90506 ±108 μs490 ±159 μs-16.1 μs (-3.2%)NO

    20 test runs in comparison
    CommitTest Runs
    dd56689
    • 2023-09-29_16:26:18.321650_cZuK
    • 2023-09-29_16:26:18.325228_rPKm
    • 2023-09-29_16:26:18.325240_HNwx
    • 2023-09-29_16:26:18.325247_WMjf
    • 2023-09-29_16:26:18.325253_NMrz
    • 2023-09-29_16:26:18.325262_cZUj
    • 2023-09-29_16:26:18.325268_QSrV
    • 2023-09-29_16:26:18.325273_vHFJ
    • 2023-09-29_16:26:18.325278_hpts
    • 2023-09-29_16:26:18.325284_kUaQ
    2d11a3a
    • 2023-10-02_14:16:42.946587_ybXz
    • 2023-10-02_14:16:42.949490_gWnp
    • 2023-10-02_14:16:42.949502_gxJO
    • 2023-10-02_14:16:42.949508_NVsP
    • 2023-10-02_14:16:42.949515_EIlf
    • 2023-10-02_14:16:42.949521_ClJU
    • 2023-10-02_14:16:42.949527_AtCR
    • 2023-10-02_14:16:42.949532_YzGU
    • 2023-10-02_14:16:42.949537_MSzd
    • 2023-10-02_14:16:42.949543_IUgW
    redfin-30
    Percentiledd566892d11a3aDiffSignificant (?)
    p10602 ±29 μs583 ±32 μs-19.1 μs (-3.2%)NO
    p25617 ±37 μs599 ±41 μs-17.6 μs (-2.9%)NO
    p50638 ±45 μs620 ±53 μs-18.2 μs (-2.9%)NO
    p75670 ±52 μs653 ±73 μs-17.5 μs (-2.6%)NO
    p90718 ±69 μs726 ±187 μs+7.92 μs (+1.1%)NO

    20 test runs in comparison
    CommitTest Runs
    dd56689
    • 2023-09-29_16:26:18.321650_cZuK
    • 2023-09-29_16:26:18.325228_rPKm
    • 2023-09-29_16:26:18.325240_HNwx
    • 2023-09-29_16:26:18.325247_WMjf
    • 2023-09-29_16:26:18.325253_NMrz
    • 2023-09-29_16:26:18.325262_cZUj
    • 2023-09-29_16:26:18.325268_QSrV
    • 2023-09-29_16:26:18.325273_vHFJ
    • 2023-09-29_16:26:18.325278_hpts
    • 2023-09-29_16:26:18.325284_kUaQ
    2d11a3a
    • 2023-10-02_14:16:42.946587_ybXz
    • 2023-10-02_14:16:42.949490_gWnp
    • 2023-10-02_14:16:42.949502_gxJO
    • 2023-10-02_14:16:42.949508_NVsP
    • 2023-10-02_14:16:42.949515_EIlf
    • 2023-10-02_14:16:42.949521_ClJU
    • 2023-10-02_14:16:42.949527_AtCR
    • 2023-10-02_14:16:42.949532_YzGU
    • 2023-10-02_14:16:42.949537_MSzd
    • 2023-10-02_14:16:42.949543_IUgW
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentiledd566892d11a3aDiffSignificant (?)
    p10204 ±6 ms204 ±2 ms-235 μs (-0.1%)NO
    p25210 ±6 ms210 ±2 ms+571 μs (+0.3%)NO
    p50217 ±7 ms218 ±2 ms+1.36 ms (+0.6%)NO
    p75225 ±7 ms228 ±3 ms+2.37 ms (+1.1%)NO
    p90234 ±7 ms242 ±7 ms+8.29 ms (+3.5%)NO

    20 test runs in comparison
    CommitTest Runs
    dd56689
    • 2023-09-29_16:26:18.321650_cZuK
    • 2023-09-29_16:26:18.325228_rPKm
    • 2023-09-29_16:26:18.325240_HNwx
    • 2023-09-29_16:26:18.325247_WMjf
    • 2023-09-29_16:26:18.325253_NMrz
    • 2023-09-29_16:26:18.325262_cZUj
    • 2023-09-29_16:26:18.325268_QSrV
    • 2023-09-29_16:26:18.325273_vHFJ
    • 2023-09-29_16:26:18.325278_hpts
    • 2023-09-29_16:26:18.325284_kUaQ
    2d11a3a
    • 2023-10-02_14:16:42.946587_ybXz
    • 2023-10-02_14:16:42.949490_gWnp
    • 2023-10-02_14:16:42.949502_gxJO
    • 2023-10-02_14:16:42.949508_NVsP
    • 2023-10-02_14:16:42.949515_EIlf
    • 2023-10-02_14:16:42.949521_ClJU
    • 2023-10-02_14:16:42.949527_AtCR
    • 2023-10-02_14:16:42.949532_YzGU
    • 2023-10-02_14:16:42.949537_MSzd
    • 2023-10-02_14:16:42.949543_IUgW
    redfin-30
    Percentiledd566892d11a3aDiffSignificant (?)
    p10245 ±4 ms264 ±4 ms+18.7 ms (+7.6%)MAYBE
    p25252 ±5 ms271 ±3 ms+18.8 ms (+7.4%)MAYBE
    p50260 ±6 ms279 ±3 ms+19.1 ms (+7.3%)MAYBE
    p75269 ±7 ms290 ±6 ms+20.2 ms (+7.5%)NO
    p90281 ±9 ms311 ±9 ms+29.3 ms (+10.4%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    dd56689
    • 2023-09-29_16:26:18.321650_cZuK
    • 2023-09-29_16:26:18.325228_rPKm
    • 2023-09-29_16:26:18.325240_HNwx
    • 2023-09-29_16:26:18.325247_WMjf
    • 2023-09-29_16:26:18.325253_NMrz
    • 2023-09-29_16:26:18.325262_cZUj
    • 2023-09-29_16:26:18.325268_QSrV
    • 2023-09-29_16:26:18.325273_vHFJ
    • 2023-09-29_16:26:18.325278_hpts
    • 2023-09-29_16:26:18.325284_kUaQ
    2d11a3a
    • 2023-10-02_14:16:42.946587_ybXz
    • 2023-10-02_14:16:42.949490_gWnp
    • 2023-10-02_14:16:42.949502_gxJO
    • 2023-10-02_14:16:42.949508_NVsP
    • 2023-10-02_14:16:42.949515_EIlf
    • 2023-10-02_14:16:42.949521_ClJU
    • 2023-10-02_14:16:42.949527_AtCR
    • 2023-10-02_14:16:42.949532_YzGU
    • 2023-10-02_14:16:42.949537_MSzd
    • 2023-10-02_14:16:42.949543_IUgW

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/IzG52FTKIz/index.html

@ehsannas ehsannas requested a review from milaGGL September 19, 2023 20:35
@ehsannas ehsannas assigned milaGGL and unassigned ehsannas Sep 29, 2023
Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehsannas ehsannas merged commit 22c314f into master Oct 2, 2023
@ehsannas ehsannas deleted the ehsann/update-or-query-tests branch October 2, 2023 16:59
@firebase firebase locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants