Skip to content

Commit 25a9d6c

Browse files
kaibolaylfkellogg
authored andcommitted
Fix test and format file. (#4341)
1 parent 4a5e96c commit 25a9d6c

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

firebase-appdistribution/src/test/java/com/google/firebase/appdistribution/impl/FirebaseAppDistributionServiceImplTest.java

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -663,8 +663,7 @@ public void startFeedback_signsInTesterAndStartsActivity() throws InterruptedExc
663663
assertThat(actualIntent.getStringExtra(RELEASE_NAME_KEY)).isEqualTo("release-name");
664664
assertThat(actualIntent.getStringExtra(SCREENSHOT_URI_KEY))
665665
.isEqualTo(TEST_SCREENSHOT_URI.toString());
666-
assertThat(actualIntent.getStringExtra(INFO_TEXT_KEY))
667-
.isEqualTo("Some terms and conditions");
666+
assertThat(actualIntent.getStringExtra(INFO_TEXT_KEY)).isEqualTo("Some terms and conditions");
668667
assertThat(firebaseAppDistribution.isFeedbackInProgress()).isTrue();
669668
}
670669

@@ -692,10 +691,8 @@ public void startFeedback_withUri_doesNotTakeScreenshot() throws InterruptedExce
692691
Intent actualIntent = shadowOf(RuntimeEnvironment.getApplication()).getNextStartedActivity();
693692
assertEquals(expectedIntent.getComponent(), actualIntent.getComponent());
694693
assertThat(actualIntent.getStringExtra(RELEASE_NAME_KEY)).isEqualTo("release-name");
695-
assertThat(actualIntent.getStringExtra(SCREENSHOT_URI_KEY))
696-
.isEqualTo(providedUri.toString());
697-
assertThat(actualIntent.getStringExtra(INFO_TEXT_KEY))
698-
.isEqualTo("Some terms and conditions");
694+
assertThat(actualIntent.getStringExtra(SCREENSHOT_URI_KEY)).isEqualTo(providedUri.toString());
695+
assertThat(actualIntent.getStringExtra(INFO_TEXT_KEY)).isEqualTo("Some terms and conditions");
699696
assertThat(firebaseAppDistribution.isFeedbackInProgress()).isTrue();
700697
}
701698

@@ -717,7 +714,13 @@ public void startFeedback_closingActivity_setsInProgressToFalse() throws Interru
717714
firebaseAppDistribution.startFeedback("Some terms and conditions");
718715
TestUtils.awaitAsyncOperations(taskExecutor);
719716
// Simulate destroying the feedback activity
720-
firebaseAppDistribution.onActivityDestroyed(new FeedbackActivity());
717+
firebaseAppDistribution.onActivityDestroyed(
718+
new FeedbackActivity() {
719+
@Override
720+
public boolean isFinishing() {
721+
return true;
722+
}
723+
});
721724

722725
assertThat(firebaseAppDistribution.isFeedbackInProgress()).isFalse();
723726
}
@@ -739,8 +742,7 @@ public void startFeedback_screenshotFails_startActivityWithNoScreenshot()
739742
assertEquals(expectedIntent.getComponent(), actualIntent.getComponent());
740743
assertThat(actualIntent.getStringExtra(RELEASE_NAME_KEY)).isEqualTo("release-name");
741744
assertThat(actualIntent.getStringExtra(SCREENSHOT_URI_KEY)).isNull();
742-
assertThat(actualIntent.getStringExtra(INFO_TEXT_KEY))
743-
.isEqualTo("Some terms and conditions");
745+
assertThat(actualIntent.getStringExtra(INFO_TEXT_KEY)).isEqualTo("Some terms and conditions");
744746
assertThat(firebaseAppDistribution.isFeedbackInProgress()).isTrue();
745747
}
746748

0 commit comments

Comments
 (0)