Skip to content

Fix test and format file #4341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2022
Merged

Fix test and format file #4341

merged 1 commit into from
Nov 18, 2022

Conversation

kaibolay
Copy link
Contributor

No description provided.

@kaibolay kaibolay requested a review from lfkellogg November 18, 2022 19:57
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@kaibolay kaibolay merged commit 3c98524 into fad/in-app-feedback Nov 18, 2022
@kaibolay kaibolay deleted the kb/format-and-finish branch November 18, 2022 20:01
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (5197b3e) to 76.74% (22e93d9) by ?.

    40 individual files with coverage change

    FilenameBase (5197b3e)Merge (22e93d9)Diff
    AabUpdater.java?98.68%?
    ApkInstaller.java?96.88%?
    ApkUpdater.java?93.75%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppIconSource.java?85.71%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?66.67%?
    AutoValue_ImageUtils_ImageSize.java?35.00%?
    AutoValue_TesterApiDisabledErrorDetails.java?29.41%?
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java?54.17%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    ErrorMessages.java?0.00%?
    FeedbackActivity.java?1.25%?
    FeedbackSender.java?90.91%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?89.86%?
    FirebaseAppDistributionLifecycleNotifier.java?96.67%?
    FirebaseAppDistributionNotificationsManager.java?85.00%?
    FirebaseAppDistributionRegistrar.java?82.05%?
    FirebaseAppDistributionTesterApiClient.java?87.63%?
    HttpsUrlConnectionFactory.java?50.00%?
    ImageUtils.java?100.00%?
    InstallActivity.java?2.53%?
    LogWrapper.java?68.75%?
    NewReleaseFetcher.java?77.55%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?85.06%?
    ReleaseUtils.java?83.33%?
    ScreenshotTaker.java?62.16%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?42.86%?
    TakeScreenshotAndStartFeedbackActivity.java?0.00%?
    TaskUtils.java?96.30%?
    TesterApiDisabledErrorDetails.java?93.75%?
    TesterApiHttpClient.java?89.47%?
    TesterSignInManager.java?93.62%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskImpl.java?75.71%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Z0YoH42QqO.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (5197b3e) and merge commit (22e93d9).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/oYOCeA7OfR.html

lfkellogg pushed a commit that referenced this pull request Nov 21, 2022
@kaibolay @lfkellogg
Fix test and format file. (#4341)
a1f3a3c
lfkellogg pushed a commit that referenced this pull request Dec 7, 2022
@kaibolay @lfkellogg
Fix test and format file. (#4341)
25a9d6c
lfkellogg pushed a commit that referenced this pull request Dec 9, 2022
@kaibolay @lfkellogg
Fix test and format file. (#4341)
883376d
@firebase firebase locked and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfkellogg lfkellogg lfkellogg approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaibolay @google-oss-bot @lfkellogg