Skip to content

Commit 3c98524

Browse files
authored
Fix test and format file. (#4341)
1 parent 5197b3e commit 3c98524

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

firebase-appdistribution/src/test/java/com/google/firebase/appdistribution/impl/FirebaseAppDistributionServiceImplTest.java

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -664,8 +664,7 @@ public void startFeedback_signsInTesterAndStartsActivity() throws InterruptedExc
664664
assertThat(actualIntent.getStringExtra(RELEASE_NAME_KEY)).isEqualTo("release-name");
665665
assertThat(actualIntent.getStringExtra(SCREENSHOT_URI_KEY))
666666
.isEqualTo(TEST_SCREENSHOT_URI.toString());
667-
assertThat(actualIntent.getStringExtra(INFO_TEXT_KEY))
668-
.isEqualTo("Some terms and conditions");
667+
assertThat(actualIntent.getStringExtra(INFO_TEXT_KEY)).isEqualTo("Some terms and conditions");
669668
assertThat(firebaseAppDistribution.isFeedbackInProgress()).isTrue();
670669
}
671670

@@ -694,10 +693,8 @@ public void startFeedback_withUri_doesNotTakeScreenshot() throws InterruptedExce
694693
Intent actualIntent = shadowOf(RuntimeEnvironment.getApplication()).getNextStartedActivity();
695694
assertEquals(expectedIntent.getComponent(), actualIntent.getComponent());
696695
assertThat(actualIntent.getStringExtra(RELEASE_NAME_KEY)).isEqualTo("release-name");
697-
assertThat(actualIntent.getStringExtra(SCREENSHOT_URI_KEY))
698-
.isEqualTo(providedUri.toString());
699-
assertThat(actualIntent.getStringExtra(INFO_TEXT_KEY))
700-
.isEqualTo("Some terms and conditions");
696+
assertThat(actualIntent.getStringExtra(SCREENSHOT_URI_KEY)).isEqualTo(providedUri.toString());
697+
assertThat(actualIntent.getStringExtra(INFO_TEXT_KEY)).isEqualTo("Some terms and conditions");
701698
assertThat(firebaseAppDistribution.isFeedbackInProgress()).isTrue();
702699
}
703700

@@ -719,7 +716,13 @@ public void startFeedback_closingActivity_setsInProgressToFalse() throws Interru
719716
firebaseAppDistribution.startFeedback("Some terms and conditions");
720717
TestUtils.awaitAsyncOperations(taskExecutor);
721718
// Simulate destroying the feedback activity
722-
firebaseAppDistribution.onActivityDestroyed(new FeedbackActivity());
719+
firebaseAppDistribution.onActivityDestroyed(
720+
new FeedbackActivity() {
721+
@Override
722+
public boolean isFinishing() {
723+
return true;
724+
}
725+
});
723726

724727
assertThat(firebaseAppDistribution.isFeedbackInProgress()).isFalse();
725728
}
@@ -741,8 +744,7 @@ public void startFeedback_screenshotFails_startActivityWithNoScreenshot()
741744
assertEquals(expectedIntent.getComponent(), actualIntent.getComponent());
742745
assertThat(actualIntent.getStringExtra(RELEASE_NAME_KEY)).isEqualTo("release-name");
743746
assertThat(actualIntent.getStringExtra(SCREENSHOT_URI_KEY)).isNull();
744-
assertThat(actualIntent.getStringExtra(INFO_TEXT_KEY))
745-
.isEqualTo("Some terms and conditions");
747+
assertThat(actualIntent.getStringExtra(INFO_TEXT_KEY)).isEqualTo("Some terms and conditions");
746748
assertThat(firebaseAppDistribution.isFeedbackInProgress()).isTrue();
747749
}
748750

0 commit comments

Comments
 (0)